[Bug] DatasetSegmentListApi in Service API returns invalid has_more and metadata when page or limit is non-positive
还没有人认领这个 Issue。
评估
调研方向
从 api/controllers/service_api/dataset/segment.py 中的 DatasetSegmentListApi.get 开始,然后将其分页处理与 api/controllers/service_api/app/annotation.py 中的 AnnotationListApi 进行比较。使用 limit=0 和非正 page 值复现请求,并验证返回的数据以及 has_more、limit 和 page 元数据使用了规范化的分页值。
由索引模型根据 Issue 内容生成。
描述
Self Checks
- I have read the Contributing Guide and Language Policy.
- This is only for bug report, if you would like to ask a question, please head to Discussions.
- I have searched for existing issues search for existing issues, including closed ones.
- I confirm that I am using English to submit this report, otherwise it will be closed.
- 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
- Please do not modify this template :) and fill in all the required fields.
Dify version
1.0.0-dev (main)
Cloud or Self Hosted
Self Hosted (Docker)
Steps to reproduce
- Inspect
DatasetSegmentListApi.getinapi/controllers/service_api/dataset/segment.py. - Notice
pageandlimit = min(args.limit, 100)are read from query arguments without callingclamp_pagination(args.page, args.limit, 100). - Send a GET request to
/v1/datasets/{dataset_id}/documents/{document_id}/segments?limit=0using a valid dataset API key for a document with existing chunks. - Inspect the returned JSON response payload.
✔️ Expected Behavior
DatasetSegmentListApi.get should normalize page and limit using clamp_pagination(args.page, args.limit, 100) (matching sibling endpoints like AnnotationListApi in api/controllers/service_api/app/annotation.py), ensuring effective_page and effective_limit are used consistently for query execution and response metadata fields (has_more, limit, page).
❌ Actual Behavior
Unclamped variables are passed directly to the response metadata:
response["has_more"]evaluates0 * 0 < total, returningtruefor any non-empty document (total > 0).- API consumers using
has_morefor pagination get trapped in infinite request loops. response["limit"]andresponse["page"]return unclamped non-positive numbers (0or negative integers), contradicting the actual returned data array.
- 主要语言
- TypeScript
- 星标
- 157k
- 派生
- 24.7k
- 平均合并
- 22 小时 32 分钟
- 30 天内合并 PR
- 611
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
langgenius/dify 的其他 Issue
-
Annotation Reply: a stored score threshold of 0.0 is silently replaced with 1, disabling the feature 未关闭
难度 2/5 1-3 小时 新手友好度 88/100
langgenius/dify#42639 · 1 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 70/100
langgenius/dify#42468 · 1 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 88/100
langgenius/dify#42355 · 1 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 88/100
langgenius/dify#42350 · 1 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 72/100
langgenius/dify#42326 · 1 条评论 · 1 个 reaction ·
相似的 Issue
-
calcite-components needs triage refactor
难度 2/5 1-3 小时 新手友好度 75/100
Esri/calcite-design-system#15203 ·
-
难度 2/5 1-3 小时 新手友好度 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
难度 1/5 1 小时以内 新手友好度 95/100
-
难度 2/5 1-3 小时 新手友好度 78/100
Automattic/studio#4908 ·
-
难度 2/5 1-3 小时 新手友好度 90/100