[Bug] DatasetSegmentListApi in Service API returns invalid has_more and metadata when page or limit is non-positive

未关闭 适合新手
#42,446 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
86/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
api, backend

调研方向

从 api/controllers/service_api/dataset/segment.py 中的 DatasetSegmentListApi.get 开始,然后将其分页处理与 api/controllers/service_api/app/annotation.py 中的 AnnotationListApi 进行比较。使用 limit=0 和非正 page 值复现请求,并验证返回的数据以及 has_more、limit 和 page 元数据使用了规范化的分页值。

由索引模型根据 Issue 内容生成。

描述

🐞 bug
Self Checks
  • I have read the Contributing Guide and Language Policy.
  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
  • Please do not modify this template :) and fill in all the required fields.
Dify version

1.0.0-dev (main)

Cloud or Self Hosted

Self Hosted (Docker)

Steps to reproduce
  1. Inspect DatasetSegmentListApi.get in api/controllers/service_api/dataset/segment.py.
  2. Notice page and limit = min(args.limit, 100) are read from query arguments without calling clamp_pagination(args.page, args.limit, 100).
  3. Send a GET request to /v1/datasets/{dataset_id}/documents/{document_id}/segments?limit=0 using a valid dataset API key for a document with existing chunks.
  4. Inspect the returned JSON response payload.
✔️ Expected Behavior

DatasetSegmentListApi.get should normalize page and limit using clamp_pagination(args.page, args.limit, 100) (matching sibling endpoints like AnnotationListApi in api/controllers/service_api/app/annotation.py), ensuring effective_page and effective_limit are used consistently for query execution and response metadata fields (has_more, limit, page).

❌ Actual Behavior

Unclamped variables are passed directly to the response metadata:

  • response["has_more"] evaluates 0 * 0 < total, returning true for any non-empty document (total > 0).
  • API consumers using has_more for pagination get trapped in infinite request loops.
  • response["limit"] and response["page"] return unclamped non-positive numbers (0 or negative integers), contradicting the actual returned data array.
主要语言
TypeScript
星标
157k
派生
24.7k
平均合并
22 小时 32 分钟
30 天内合并 PR
611

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

langgenius/dify 的其他 Issue

查看 langgenius/dify 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。