[Refactor/Chore] Preserve the Amplitude lazy-loading boundary in tracking utilities
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 55/100
- issue の種類
- リファクタリング
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- typescript
調査の方向性
Start by building the Vinext browser target and inspecting the client manifest’s static imports. Trace web/app/components/base/amplitude/lazy-amplitude-provider.tsx, amplitude/index.ts, utils.ts, init.ts, app/components/main-nav/layout.tsx, and CloudAnalyticsLayoutBoundary. Done means the SDK implementation is not statically pulled in by lightweight consumers, while consent, initialization, identity, opt-out, registration flushing, and synchronization behavior remain intact; compare build graphs and transferred JavaScript.
索引モデルが issue の本文から書いたものです。
説明
Self Checks
- I have read the Contributing Guide and Language Policy.
- This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
- I have searched for existing issues search for existing issues, including closed ones.
- I confirm that I am using English to submit this report, otherwise it will be closed.
- 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
- Please do not modify this template :) and fill in all the required fields.
Description
Keep Amplitude SDK implementation imports behind the analytics activation boundary. The provider is dynamically imported, but common tracking utilities bypass that boundary through static imports:
web/app/components/base/amplitude/lazy-amplitude-provider.tsxdynamically importsAmplitudeProvider.amplitude/index.tsalso re-exports tracking and identity functions fromutils.ts.utils.tsstatically imports@amplitude/analytics-browserandgetIsAmplitudeInitializedfrom./init.init.tsstatically imports both@amplitude/analytics-browserand@amplitude/plugin-session-replay-browser.- Navigation/account UI and external-service synchronization use these utilities.
A local Rolldown client build confirms the static manifest chain:
app/components/main-nav/layout.tsx
→ _help-menu-D6_0F4Dx.js
→ _utils-UCOVMtae.js
CloudAnalyticsLayoutBoundary also statically imports the utils chunk. That shared chunk contains 187 modules and is 337,689 bytes, approximately 92,891 bytes gzip. These are shared-chunk sizes, not guaranteed savings or measured production network transfer. Several replay recording modules remain dynamic imports; their entire package sizes should not be counted as eager payload.
Reproduce by building the Vinext browser target, inspecting the client manifest's static imports, and tracing the utilities above. The provider's dynamic import alone does not prevent the SDK from being reached statically elsewhere.
Motivation
Checking consent or API-key availability before SDK calls does not defer static imports. This is a loading/performance issue, not evidence of analytics events being sent before consent.
Suggested direction: keep initialization status and listeners in a lightweight module, and lazily load the SDK implementation only when analytics is eligible to activate. Audit utility/barrel imports so they do not reintroduce an eager path.
Acceptance criteria:
- Verify production requests with consent denied, analytics disabled/no API key, and consent granted.
- Ensure lightweight tracking/status consumers do not statically pull in the SDK initialization implementation.
- Preserve registration-event flushing, identity synchronization, initialization notification, opt-out behavior, and consent transitions.
- Compare before/after build graphs and transferred JS; do not claim the entire shared chunk as savings without measurement.
Additional Context
Measured on a local Dify 1.17.1 development branch based on 06e473015a9a1abb71da88ac0a0e92d96a992008, with local DevTools integration patches, using Vinext 1.0.0-beta.10, Vite+ core 0.3.2, and Node 24.21.0. Browser analysis session: sid_4_1789651325793 (12,219 modules). Recheck against current main when implementing.
Related closed work: #33887 discussed lazy initializers and dev cold-load performance; #38514 separated bootstrap/external-service responsibilities. This report specifically tracks the remaining static SDK path in production build output.
- 主要言語
- TypeScript
- スター
- 157k
- フォーク
- 24.7k
- 平均マージ
- 22時間 32分
- マージ済み PR(30日)
- 611
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
langgenius/dify のほかの issue
-
Annotation Reply: a stored score threshold of 0.0 is silently replaced with 1, disabling the feature オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
langgenius/dify#42639 · コメント 1 件 · リアクション 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
langgenius/dify#42468 · コメント 1 件 · リアクション 1 件 ·
-
🐞 bug
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
langgenius/dify#42446 · リアクション 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
langgenius/dify#42355 · コメント 1 件 · リアクション 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
langgenius/dify#42350 · コメント 1 件 · リアクション 1 件 ·
langgenius/dify の issue をすべて見る
似ている issue
-
calcite-components needs triage refactor
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
Esri/calcite-design-system#15203 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
難易度 1/5 1時間未満 初心者へのやさしさ 95/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
Automattic/studio#4908 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 90/100