RawGooglePayButton: set up custom height (native PayButton doesn't fill platform view)
还没有人认领这个 Issue。
评估
调研方向
Start by reading PayButtonView.kt, where the Android platform view creates and initializes the native PayButton; compare its layout behavior with the Flutter widget sizing described in the report. Check the related platform view tests or add a reproduction for a 64dp parent height. Done means the native button fills the height supplied by Flutter without breaking its content or existing button behavior.
由索引模型根据 Issue 内容生成。
描述
Describe the bug
RawGooglePayButton cannot be made taller than 48dp. When it is wrapped in a SizedBox with a larger height, for example 64, the platform view takes the full 64dp. The native Google Pay button stays 48dp tall at the top of it, with 16dp of empty space below.
The same happens with GooglePayButton, which wraps RawGooglePayButton.
To Reproduce
- Add the following widget on an Android device or emulator:
SizedBox(
width: double.infinity,
height: 64,
child: RawGooglePayButton(
paymentConfiguration: PaymentConfiguration.fromJsonString('''
{
"provider": "google_pay",
"data": {
"environment": "TEST",
"apiVersion": 2,
"apiVersionMinor": 0,
"allowedPaymentMethods": []
}
}
'''),
onPressed: () {},
),
);
- The button is drawn 48dp tall, not 64dp.
Expected behavior
The button fills the height given by its parent.
Screenshots
Additional context
This problem was already described here but it was closed by author for unknown reasons: https://github.com/google-pay/flutter-plugin/issues/256
Workaround
This is an AI-generated workaround that makes the button fills the height. I can open a PR if the approach is acceptable:
- In
PayButtonView.kt, afterpayButton.initialize(...), setMATCH_PARENTwidth and height on the inflated containerViewGroups.
Code:
/**
* Copyright 2025 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.flutter.plugins.pay_android.view
import android.content.Context
import android.view.ViewGroup
import android.view.ViewGroup.LayoutParams.MATCH_PARENT
import com.google.android.gms.wallet.button.ButtonOptions
import com.google.android.gms.wallet.button.ButtonConstants.ButtonTheme
import com.google.android.gms.wallet.button.ButtonConstants.ButtonType
import com.google.android.gms.wallet.button.PayButton
import io.flutter.plugin.common.BinaryMessenger
import io.flutter.plugin.common.MethodChannel
import io.flutter.plugin.platform.PlatformView
import org.json.JSONArray
import org.json.JSONObject
private const val VIEW_TYPE = "plugins.flutter.io/pay/google_pay_button"
private const val METHOD_ON_PRESSED = "onPressed"
internal class PayButtonView(private val context: Context, binaryMessenger: BinaryMessenger, viewId: Int, creationParams: Map<String, Any>) : PlatformView {
private val payButton: PayButton
private val methodChannel: MethodChannel
init {
// Instantiate method channel
methodChannel = MethodChannel(binaryMessenger, "$VIEW_TYPE/$viewId");
// Build pay button
payButton = PayButton(context)
buildPayButton(creationParams)
}
private fun buildPayButton(buttonParams: Map<String, Any>) {
val buttonTheme = ButtonThemeFactory.fromString(buttonParams["theme"] as String)
val buttonType = ButtonTypeFactory.fromString(buttonParams["type"] as String)
val cornerRadiusDp = buttonParams["cornerRadius"] as Int
val cornerRadius = (cornerRadiusDp * context.resources.displayMetrics.density).toInt()
// Parse payment configuration
val payConfiguration = JSONObject(buttonParams["paymentConfiguration"] as String)
val allowedPaymentMethods: JSONArray = payConfiguration["allowedPaymentMethods"] as JSONArray
payButton.initialize(ButtonOptions.newBuilder()
.setButtonTheme(buttonTheme)
.setButtonType(buttonType)
.setCornerRadius(cornerRadius)
.setAllowedPaymentMethods(allowedPaymentMethods.toString())
.build())
stretchToFill(payButton)
payButton.setOnClickListener {
methodChannel.invokeMethod(METHOD_ON_PRESSED, null)
}
}
// The inflated button container is wrap_content with a 48dp minimum height, so
// it must be stretched to follow the height given by the Flutter side. Leaf
// views (logo, text) keep their own size.
private fun stretchToFill(group: ViewGroup) {
group.layoutParams?.let {
it.width = MATCH_PARENT
it.height = MATCH_PARENT
group.layoutParams = it
}
for (i in 0 until group.childCount) {
(group.getChildAt(i) as? ViewGroup)?.let(::stretchToFill)
}
}
override fun getView() = payButton
override fun dispose() = Unit
}
class ButtonThemeFactory {
companion object {
fun fromString(buttonThemeString: String) = when(buttonThemeString) {
"dark" -> ButtonTheme.DARK
"light" -> ButtonTheme.LIGHT
else -> ButtonTheme.DARK
}
}
}
class ButtonTypeFactory {
companion object {
fun fromString(buttonTypeString: String) = when(buttonTypeString) {
"pay" -> ButtonType.PAY
"buy" -> ButtonType.BUY
"book" -> ButtonType.BOOK
"donate" -> ButtonType.DONATE
"checkout" -> ButtonType.CHECKOUT
"order" -> ButtonType.ORDER
"plain" -> ButtonType.PLAIN
"subscribe" -> ButtonType.SUBSCRIBE
"pix" -> ButtonType.PIX
else -> ButtonType.BUY
}
}
}
- 主要语言
- Dart
- 星标
- 180
- 派生
- 144
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
google-pay/flutter-plugin 的其他 Issue
-
Unable to load asset: "packages/pay_platform_interface/pubspec.yaml".可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 3/5 1-2 天 新手友好度 42/100
google-pay/flutter-plugin#331 ·
-
难度 4/5 3-5 天 新手友好度 52/100
google-pay/flutter-plugin#323 · 3 条评论 · 1 个 reaction ·
-
Apple Pay Bottom Sheet – Incorrect Failure Design Handling After Backend Call Using Apple Pay Token未关闭
难度 5/5 一周以上 新手友好度 25/100
google-pay/flutter-plugin#322 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 52/100
google-pay/flutter-plugin#321 · 2 条评论 · 9 个 reaction ·
-
难度 4/5 3-5 天 新手友好度 40/100
google-pay/flutter-plugin#312 · 1 条评论 ·
查看 google-pay/flutter-plugin 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
Tencent/tdesign-flutter#1229 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
VeryGoodOpenSource/very_good_analysis#254 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
berkmancenter/frankly#732 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
rodydavis/signals.dart#510 ·