RawGooglePayButton: set up custom height (native PayButton doesn't fill platform view)
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 52/100
Piste de recherche
Start by reading PayButtonView.kt, where the Android platform view creates and initializes the native PayButton; compare its layout behavior with the Flutter widget sizing described in the report. Check the related platform view tests or add a reproduction for a 64dp parent height. Done means the native button fills the height supplied by Flutter without breaking its content or existing button behavior.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Describe the bug
RawGooglePayButton cannot be made taller than 48dp. When it is wrapped in a SizedBox with a larger height, for example 64, the platform view takes the full 64dp. The native Google Pay button stays 48dp tall at the top of it, with 16dp of empty space below.
The same happens with GooglePayButton, which wraps RawGooglePayButton.
To Reproduce
- Add the following widget on an Android device or emulator:
SizedBox(
width: double.infinity,
height: 64,
child: RawGooglePayButton(
paymentConfiguration: PaymentConfiguration.fromJsonString('''
{
"provider": "google_pay",
"data": {
"environment": "TEST",
"apiVersion": 2,
"apiVersionMinor": 0,
"allowedPaymentMethods": []
}
}
'''),
onPressed: () {},
),
);
- The button is drawn 48dp tall, not 64dp.
Expected behavior
The button fills the height given by its parent.
Screenshots
Additional context
This problem was already described here but it was closed by author for unknown reasons: https://github.com/google-pay/flutter-plugin/issues/256
Workaround
This is an AI-generated workaround that makes the button fills the height. I can open a PR if the approach is acceptable:
- In
PayButtonView.kt, afterpayButton.initialize(...), setMATCH_PARENTwidth and height on the inflated containerViewGroups.
Code:
/**
* Copyright 2025 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.flutter.plugins.pay_android.view
import android.content.Context
import android.view.ViewGroup
import android.view.ViewGroup.LayoutParams.MATCH_PARENT
import com.google.android.gms.wallet.button.ButtonOptions
import com.google.android.gms.wallet.button.ButtonConstants.ButtonTheme
import com.google.android.gms.wallet.button.ButtonConstants.ButtonType
import com.google.android.gms.wallet.button.PayButton
import io.flutter.plugin.common.BinaryMessenger
import io.flutter.plugin.common.MethodChannel
import io.flutter.plugin.platform.PlatformView
import org.json.JSONArray
import org.json.JSONObject
private const val VIEW_TYPE = "plugins.flutter.io/pay/google_pay_button"
private const val METHOD_ON_PRESSED = "onPressed"
internal class PayButtonView(private val context: Context, binaryMessenger: BinaryMessenger, viewId: Int, creationParams: Map<String, Any>) : PlatformView {
private val payButton: PayButton
private val methodChannel: MethodChannel
init {
// Instantiate method channel
methodChannel = MethodChannel(binaryMessenger, "$VIEW_TYPE/$viewId");
// Build pay button
payButton = PayButton(context)
buildPayButton(creationParams)
}
private fun buildPayButton(buttonParams: Map<String, Any>) {
val buttonTheme = ButtonThemeFactory.fromString(buttonParams["theme"] as String)
val buttonType = ButtonTypeFactory.fromString(buttonParams["type"] as String)
val cornerRadiusDp = buttonParams["cornerRadius"] as Int
val cornerRadius = (cornerRadiusDp * context.resources.displayMetrics.density).toInt()
// Parse payment configuration
val payConfiguration = JSONObject(buttonParams["paymentConfiguration"] as String)
val allowedPaymentMethods: JSONArray = payConfiguration["allowedPaymentMethods"] as JSONArray
payButton.initialize(ButtonOptions.newBuilder()
.setButtonTheme(buttonTheme)
.setButtonType(buttonType)
.setCornerRadius(cornerRadius)
.setAllowedPaymentMethods(allowedPaymentMethods.toString())
.build())
stretchToFill(payButton)
payButton.setOnClickListener {
methodChannel.invokeMethod(METHOD_ON_PRESSED, null)
}
}
// The inflated button container is wrap_content with a 48dp minimum height, so
// it must be stretched to follow the height given by the Flutter side. Leaf
// views (logo, text) keep their own size.
private fun stretchToFill(group: ViewGroup) {
group.layoutParams?.let {
it.width = MATCH_PARENT
it.height = MATCH_PARENT
group.layoutParams = it
}
for (i in 0 until group.childCount) {
(group.getChildAt(i) as? ViewGroup)?.let(::stretchToFill)
}
}
override fun getView() = payButton
override fun dispose() = Unit
}
class ButtonThemeFactory {
companion object {
fun fromString(buttonThemeString: String) = when(buttonThemeString) {
"dark" -> ButtonTheme.DARK
"light" -> ButtonTheme.LIGHT
else -> ButtonTheme.DARK
}
}
}
class ButtonTypeFactory {
companion object {
fun fromString(buttonTypeString: String) = when(buttonTypeString) {
"pay" -> ButtonType.PAY
"buy" -> ButtonType.BUY
"book" -> ButtonType.BOOK
"donate" -> ButtonType.DONATE
"checkout" -> ButtonType.CHECKOUT
"order" -> ButtonType.ORDER
"plain" -> ButtonType.PLAIN
"subscribe" -> ButtonType.SUBSCRIBE
"pix" -> ButtonType.PIX
else -> ButtonType.BUY
}
}
}
- Langage dominant
- Dart
- Étoiles
- 180
- Forks
- 144
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de google-pay/flutter-plugin
-
Unable to load asset: "packages/pay_platform_interface/pubspec.yaml".Peut-être à nouveau libre Une pull request pour cette issue a été fermée sans être fusionnée. Ouverte
Difficulté 3/5 1-2 jours Accessibilité débutants 42/100
google-pay/flutter-plugin#331 ·
-
Difficulté 4/5 3-5 jours Accessibilité débutants 52/100
google-pay/flutter-plugin#323 · 3 commentaires · 1 réaction ·
-
Apple Pay Bottom Sheet – Incorrect Failure Design Handling After Backend Call Using Apple Pay TokenOuverte
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 25/100
google-pay/flutter-plugin#322 · 1 commentaire ·
-
Difficulté 3/5 1-2 jours Accessibilité débutants 52/100
google-pay/flutter-plugin#321 · 2 commentaires · 9 réactions ·
-
Difficulté 4/5 3-5 jours Accessibilité débutants 40/100
google-pay/flutter-plugin#312 · 1 commentaire ·
Toutes les issues de google-pay/flutter-plugin
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
aaronified/fluenough#918 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 5 jours
-
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
Les mainteneurs répondent en général sous 4 jours
-
enhancement
Difficulté 2/5 1-3 heures Accessibilité débutants 69/100
Les mainteneurs répondent en général sous 3 jours
-
area-clientside-dartpad
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
Les mainteneurs répondent en général sous 2 jours