RawGooglePayButton: set up custom height (native PayButton doesn't fill platform view)
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 52/100
調査の方向性
Start by reading PayButtonView.kt, where the Android platform view creates and initializes the native PayButton; compare its layout behavior with the Flutter widget sizing described in the report. Check the related platform view tests or add a reproduction for a 64dp parent height. Done means the native button fills the height supplied by Flutter without breaking its content or existing button behavior.
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
RawGooglePayButton cannot be made taller than 48dp. When it is wrapped in a SizedBox with a larger height, for example 64, the platform view takes the full 64dp. The native Google Pay button stays 48dp tall at the top of it, with 16dp of empty space below.
The same happens with GooglePayButton, which wraps RawGooglePayButton.
To Reproduce
- Add the following widget on an Android device or emulator:
SizedBox(
width: double.infinity,
height: 64,
child: RawGooglePayButton(
paymentConfiguration: PaymentConfiguration.fromJsonString('''
{
"provider": "google_pay",
"data": {
"environment": "TEST",
"apiVersion": 2,
"apiVersionMinor": 0,
"allowedPaymentMethods": []
}
}
'''),
onPressed: () {},
),
);
- The button is drawn 48dp tall, not 64dp.
Expected behavior
The button fills the height given by its parent.
Screenshots
Additional context
This problem was already described here but it was closed by author for unknown reasons: https://github.com/google-pay/flutter-plugin/issues/256
Workaround
This is an AI-generated workaround that makes the button fills the height. I can open a PR if the approach is acceptable:
- In
PayButtonView.kt, afterpayButton.initialize(...), setMATCH_PARENTwidth and height on the inflated containerViewGroups.
Code:
/**
* Copyright 2025 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.flutter.plugins.pay_android.view
import android.content.Context
import android.view.ViewGroup
import android.view.ViewGroup.LayoutParams.MATCH_PARENT
import com.google.android.gms.wallet.button.ButtonOptions
import com.google.android.gms.wallet.button.ButtonConstants.ButtonTheme
import com.google.android.gms.wallet.button.ButtonConstants.ButtonType
import com.google.android.gms.wallet.button.PayButton
import io.flutter.plugin.common.BinaryMessenger
import io.flutter.plugin.common.MethodChannel
import io.flutter.plugin.platform.PlatformView
import org.json.JSONArray
import org.json.JSONObject
private const val VIEW_TYPE = "plugins.flutter.io/pay/google_pay_button"
private const val METHOD_ON_PRESSED = "onPressed"
internal class PayButtonView(private val context: Context, binaryMessenger: BinaryMessenger, viewId: Int, creationParams: Map<String, Any>) : PlatformView {
private val payButton: PayButton
private val methodChannel: MethodChannel
init {
// Instantiate method channel
methodChannel = MethodChannel(binaryMessenger, "$VIEW_TYPE/$viewId");
// Build pay button
payButton = PayButton(context)
buildPayButton(creationParams)
}
private fun buildPayButton(buttonParams: Map<String, Any>) {
val buttonTheme = ButtonThemeFactory.fromString(buttonParams["theme"] as String)
val buttonType = ButtonTypeFactory.fromString(buttonParams["type"] as String)
val cornerRadiusDp = buttonParams["cornerRadius"] as Int
val cornerRadius = (cornerRadiusDp * context.resources.displayMetrics.density).toInt()
// Parse payment configuration
val payConfiguration = JSONObject(buttonParams["paymentConfiguration"] as String)
val allowedPaymentMethods: JSONArray = payConfiguration["allowedPaymentMethods"] as JSONArray
payButton.initialize(ButtonOptions.newBuilder()
.setButtonTheme(buttonTheme)
.setButtonType(buttonType)
.setCornerRadius(cornerRadius)
.setAllowedPaymentMethods(allowedPaymentMethods.toString())
.build())
stretchToFill(payButton)
payButton.setOnClickListener {
methodChannel.invokeMethod(METHOD_ON_PRESSED, null)
}
}
// The inflated button container is wrap_content with a 48dp minimum height, so
// it must be stretched to follow the height given by the Flutter side. Leaf
// views (logo, text) keep their own size.
private fun stretchToFill(group: ViewGroup) {
group.layoutParams?.let {
it.width = MATCH_PARENT
it.height = MATCH_PARENT
group.layoutParams = it
}
for (i in 0 until group.childCount) {
(group.getChildAt(i) as? ViewGroup)?.let(::stretchToFill)
}
}
override fun getView() = payButton
override fun dispose() = Unit
}
class ButtonThemeFactory {
companion object {
fun fromString(buttonThemeString: String) = when(buttonThemeString) {
"dark" -> ButtonTheme.DARK
"light" -> ButtonTheme.LIGHT
else -> ButtonTheme.DARK
}
}
}
class ButtonTypeFactory {
companion object {
fun fromString(buttonTypeString: String) = when(buttonTypeString) {
"pay" -> ButtonType.PAY
"buy" -> ButtonType.BUY
"book" -> ButtonType.BOOK
"donate" -> ButtonType.DONATE
"checkout" -> ButtonType.CHECKOUT
"order" -> ButtonType.ORDER
"plain" -> ButtonType.PLAIN
"subscribe" -> ButtonType.SUBSCRIBE
"pix" -> ButtonType.PIX
else -> ButtonType.BUY
}
}
}
- 主要言語
- Dart
- スター
- 180
- フォーク
- 145
- PR マージ指標
- 30日以内にマージされた PR はありません
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
google-pay/flutter-plugin のほかの issue
-
Unable to load asset: "packages/pay_platform_interface/pubspec.yaml".再び着手できるかも このイシューのプルリクエストはマージされずにクローズされました。 オープン
難易度 3/5 1〜2日 初心者へのやさしさ 42/100
google-pay/flutter-plugin#331 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 52/100
google-pay/flutter-plugin#323 · コメント 3 件 · リアクション 1 件 ·
-
Apple Pay Bottom Sheet – Incorrect Failure Design Handling After Backend Call Using Apple Pay Tokenオープン
難易度 5/5 1週間以上 初心者へのやさしさ 25/100
google-pay/flutter-plugin#322 · コメント 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 52/100
google-pay/flutter-plugin#321 · コメント 2 件 · リアクション 9 件 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 40/100
google-pay/flutter-plugin#312 · コメント 1 件 ·
google-pay/flutter-plugin の issue をすべて見る
似ている issue
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
lollipopkit/flutter_server_box#1851 · コメント 1 件 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
type:feature
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
mikejr83/rc-soar-score#724 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
ccch1mneyyy/dsh-Go#381 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
letsar/flutter_slidable#563 ·
メンテナーはふだん 1 日以内に返信
-
bot-found bug priority: P3
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
madenvel/KalinkaPlayer#498 ·