settings reprotect: name the default key, report values it cannot reach, and settle rows of unregistered areas

未关闭
#3,436 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
54/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp

调研方向

Start with the fluentcms settings reprotect implementation and its tests, then read the related behavior in #3364 and #3433. The issue also points to docs/host-configuration.md; inspect how settings areas and cached key rings are handled before choosing the unregistered-area cleanup behavior. Done means the output names the default key id, unreachable protected values are reported without revealing values, the cleanup path is decided and documented, and tests cover the command changes.

由索引模型根据 Issue 内容生成。

描述

area:settings type:bug

Follow-ups of fluentcms settings reprotect (#3364, #3433), found in its review. None loses or shows a secret.

  • The command does not say which ring key it protected under. It ends with exit code 0 whatever the default key is. Run before the key that is to be kept has become the default, it succeeds, and retiring the old key afterwards still loses the secrets. Name the id of the default key in the output; the id is not secret.
  • Protected values the pass cannot reach in a registered area are skipped without a word. A fcms-protected:v1: value under a key the class no longer has, or no longer marks as a secret, is left as it is and the command ends with 0. Rows of an area no class registers are reported; these are not.
  • No way to remove the settings rows of an area no class registers. A host that removed a plugin with secret settings gets exit code 1 from every run, and neither the API nor reset knows the area.
  • The docs do not say when an instance may still write under the old key. A running instance caches the ring for up to 24 hours, so with a key made by hand it can protect a write under the old default after the pass. Say when to run the pass, or that the instances are restarted first.

Wanted

  • The default key's id in the command's output, with a test.
  • Such values reported by area and scope, never by value, with a test.
  • A decision on the rows of an unregistered area: a command or an option that removes them, or the documented way to do it.
  • The sentence in docs/host-configuration.md.

Found in the review of #3433. Bundle 25.

主要语言
C#
星标
567
派生
107
平均合并
1 小时 19 分钟
30 天内合并 PR
353

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。