settings reprotect: name the default key, report values it cannot reach, and settle rows of unregistered areas

オープン
#3,436 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
54/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
csharp

調査の方向性

Start with the fluentcms settings reprotect implementation and its tests, then read the related behavior in #3364 and #3433. The issue also points to docs/host-configuration.md; inspect how settings areas and cached key rings are handled before choosing the unregistered-area cleanup behavior. Done means the output names the default key id, unreachable protected values are reported without revealing values, the cleanup path is decided and documented, and tests cover the command changes.

索引モデルが issue の本文から書いたものです。

説明

area:settings type:bug

Follow-ups of fluentcms settings reprotect (#3364, #3433), found in its review. None loses or shows a secret.

  • The command does not say which ring key it protected under. It ends with exit code 0 whatever the default key is. Run before the key that is to be kept has become the default, it succeeds, and retiring the old key afterwards still loses the secrets. Name the id of the default key in the output; the id is not secret.
  • Protected values the pass cannot reach in a registered area are skipped without a word. A fcms-protected:v1: value under a key the class no longer has, or no longer marks as a secret, is left as it is and the command ends with 0. Rows of an area no class registers are reported; these are not.
  • No way to remove the settings rows of an area no class registers. A host that removed a plugin with secret settings gets exit code 1 from every run, and neither the API nor reset knows the area.
  • The docs do not say when an instance may still write under the old key. A running instance caches the ring for up to 24 hours, so with a key made by hand it can protect a write under the old default after the pass. Say when to run the pass, or that the instances are restarted first.

Wanted

  • The default key's id in the command's output, with a test.
  • Such values reported by area and scope, never by value, with a test.
  • A decision on the rows of an unregistered area: a command or an option that removes them, or the documented way to do it.
  • The sentence in docs/host-configuration.md.

Found in the review of #3433. Bundle 25.

主要言語
C#
スター
567
フォーク
107
平均マージ
1時間 19分
マージ済み PR(30日)
353

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

fluentcms/FluentCMS のほかの issue

fluentcms/FluentCMS の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。