settings reprotect: name the default key, report values it cannot reach, and settle rows of unregistered areas

Ouverte
#3,436 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
54/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
csharp

Piste de recherche

Start with the fluentcms settings reprotect implementation and its tests, then read the related behavior in #3364 and #3433. The issue also points to docs/host-configuration.md; inspect how settings areas and cached key rings are handled before choosing the unregistered-area cleanup behavior. Done means the output names the default key id, unreachable protected values are reported without revealing values, the cleanup path is decided and documented, and tests cover the command changes.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:settings type:bug

Follow-ups of fluentcms settings reprotect (#3364, #3433), found in its review. None loses or shows a secret.

  • The command does not say which ring key it protected under. It ends with exit code 0 whatever the default key is. Run before the key that is to be kept has become the default, it succeeds, and retiring the old key afterwards still loses the secrets. Name the id of the default key in the output; the id is not secret.
  • Protected values the pass cannot reach in a registered area are skipped without a word. A fcms-protected:v1: value under a key the class no longer has, or no longer marks as a secret, is left as it is and the command ends with 0. Rows of an area no class registers are reported; these are not.
  • No way to remove the settings rows of an area no class registers. A host that removed a plugin with secret settings gets exit code 1 from every run, and neither the API nor reset knows the area.
  • The docs do not say when an instance may still write under the old key. A running instance caches the ring for up to 24 hours, so with a key made by hand it can protect a write under the old default after the pass. Say when to run the pass, or that the instances are restarted first.

Wanted

  • The default key's id in the command's output, with a test.
  • Such values reported by area and scope, never by value, with a test.
  • A decision on the rows of an unregistered area: a command or an option that removes them, or the documented way to do it.
  • The sentence in docs/host-configuration.md.

Found in the review of #3433. Bundle 25.

Langage dominant
C#
Étoiles
567
Forks
107
Merge moyen
1 h 19 min
PR mergées (30 j)
353

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de fluentcms/FluentCMS

Toutes les issues de fluentcms/FluentCMS

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.