database.name should namespace schema names on MySQL, as it does on PostgreSQL
维护者通常 1 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 15/100
调研方向
Start with Connection.schema_prefix and Connection.qualify_schema_name, then Schema.activate, list_schemas and the MySQL database.name warning, which the linked PR #1583 already changes. Open design questions (separator, already-prefixed names, lineage, opt-out, removal release) need maintainer decisions before any patch. Done means the unit prefix rule and the MySQL and PostgreSQL integration tests pass, and the docs follow-up is written.
由索引模型根据 Issue 内容生成。
描述
What happens now
When several projects share one database server, each project needs its own set of schemas: two pipelines that both declare dj.Schema("subject") must not write to the same tables, and an administrator wants to grant a project's users access to that project's schemas only.
-
PostgreSQL:
database.name(DJ_DATABASE_NAME) selects the database. Each project gets its own database, the pipeline writesdj.Schema("subject"), and the projects stay apart. -
MySQL:
database.nameis ignored, with the warning "database.name is set but the MySQL backend does not support database selection". The only way to separate projects is to put a prefix into every schema name in pipeline code:prefix = os.environ["MY_PREFIX"] # or dj.config.database.database_prefix subject = dj.Schema(prefix + "subject") session = dj.Schema(prefix + "session") -
database.database_prefix(DJ_DATABASE_PREFIX): it stores the value but DataJoint never applies it. It is deprecated with the message "will be removed in DataJoint 2.3. Use database.name to select a PostgreSQL database instead". That message is stale on 2.3.x, and it gives MySQL users no replacement.
So the same pipeline is written differently for the two backends. Every MySQL pipeline carries its own prefix handling, and a published example that writes dj.Schema("subject") can't be dropped into a shared MySQL server unchanged.
Proposal
Make database.name the connection's schema namespace on both backends:
| Backend | database.name = "lab_project" |
dj.Schema("subject") on the server |
|---|---|---|
| PostgreSQL | connects to database lab_project (unchanged) |
schema subject in database lab_project |
| MySQL | prefix lab_project_ |
schema lab_project_subject |
- Prefixing.
Schemaadds the prefix itself, so pipelines write plain schema names on both backends. This also coversVirtualModule,virtual_schemaandSchema.activate. schema.database. It is the name on the server (lab_project_subject), as it is today for any schema.dj.list_schemas(). It lists the namespace's schemas under their plain names (subject), so every name it returns can be passed back todj.Schema. A connection withoutdatabase.namestill lists every schema it can see.- Grants. Access is granted by pattern on MySQL (
GRANT ... ON \lab_project_%`.*`) and by database on PostgreSQL. - Already-prefixed names. A name that already starts with the prefix is used as is, with a warning ("write
subjectinstead"). Code that still prefixes by hand keeps reaching the same schemas rather than silently creatinglab_project_lab_project_subject. database_prefix. It stays deprecated and unapplied. Its message points todatabase.name, and the "removed in 2.3" text goes.
Compatibility. A MySQL user who sets database.name today gets a warning and no effect. After this change, their schema names gain the prefix: for example, an environment that sets DJ_DATABASE_NAME for a PostgreSQL database and is reused against MySQL. That is a behaviour change, so it belongs in a minor release, with a note in the release notes.
Migration for a MySQL deployment that prefixes by hand with myproject_: set database.name = "myproject", then drop the prefix from the pipeline's dj.Schema(...) calls. The schemas on the server do not change.
Questions to settle
- Separator. The proposal adds
_itself (name + "_"). The alternative is to take the prefix verbatim, asdatabase_prefixdid. Adding_keepsdatabase.namea name rather than a fragment, and matches the commonproject_convention. - Already-prefixed names. Should they be used as is with a warning, or raise an error? A warning makes migration safe. The cost is one edge case: with namespace
lab, a schema meant to be namedlab_sessionresolves tolab_sessionrather thanlab_lab_session. - Lineage. Lineage strings embed the schema's server name (
schema.table.attribute). On MySQL the prefix becomes part of them; on PostgreSQL the database name does not. Restoring a namespace under a different name then needsschema.rebuild_lineage()on MySQL only. Should lineage record the plain name instead? - Reaching outside the namespace. On PostgreSQL a connection cannot reach another database. On MySQL the prefix confines
dj.Schemato the namespace. A shared reference schema outside it would need either a second connection withoutdatabase.nameor an explicit opt-out (e.g.dj.Schema(name, namespace=False)). The proposal leaves the opt-out out of the first version. - Removing
database_prefix. In which release?
Implementation
The behaviour above is implemented and tested in the linked PR:
Connection.schema_prefixandConnection.qualify_schema_name;Schema.activateapplies the prefix, andlist_schemasfilters and strips it;- the MySQL warning is removed and the deprecation message updated.
Tests:
- Unit: the prefix rule on both backends.
- Integration (MySQL and PostgreSQL): two namespaces each hold a
subjectschema with separate contents;list_schemasreturns plain names;VirtualModuleresolves inside the namespace; an already-prefixed name is not prefixed twice. - Results: unit 457 passed; integration 694 passed, 16 skipped, both backends.
Related: #1426 (added database.name for PostgreSQL and deprecated database_prefix), #1351 (renamed schema_prefix to database_prefix).
Docs follow-up: how-to/configure-database.md, how-to/deploy-production.md §Use Database Prefixes, reference/configuration.md.
- 主要语言
- Python
- 星标
- 197
- 派生
- 98
- 平均合并
- 15 小时 31 分钟
- 30 天内合并 PR
- 9
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
datajoint/datajoint-python 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
datajoint/datajoint-python#1581 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
datajoint/datajoint-python#1539 · 3 条评论 ·
维护者通常 1 天内回复
-
_job_start_time records the populating host's local time, with no zone可能已有人在做 @dimitri-yatsenko 今天认领。 未关闭
datajoint/datajoint-python#1584 · 已指派 1 人 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 40/100
datajoint/datajoint-python#1580 ·
维护者通常 1 天内回复
-
A column copied by a foreign key loses the parent's core type (int32 becomes int)可能已有人在做 @dimitri-yatsenko 于 3 天前认领。 未关闭
难度 3/5 半天 新手友好度 25/100
datajoint/datajoint-python#1578 ·
维护者通常 1 天内回复
查看 datajoint/datajoint-python 的全部 Issue
相似的 Issue
-
bug
难度 1/5 1 小时以内 新手友好度 88/100
openwisp/openwisp-utils#777 ·
-
难度 2/5 1-3 小时 新手友好度 63/100
google-research/weatherbenchX#310 ·
维护者通常 3 天内回复
-
`unload()` returns the trained `modules_to_save` copy instead of the original module可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
huggingface/peft#3955 ·
维护者通常 1 天内回复
-
author-page correction
难度 2/5 1-3 小时 新手友好度 60/100
acl-org/acl-anthology#10313 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
AOSSIE-Org/Gitcord-GithubDiscordBot#147 · 1 条评论 ·
维护者通常 1 天内回复