database.name should namespace schema names on MySQL, as it does on PostgreSQL
Mantenedores costumam responder em até 1 dia
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 15/100
Direção de pesquisa
Start with Connection.schema_prefix and Connection.qualify_schema_name, then Schema.activate, list_schemas and the MySQL database.name warning, which the linked PR #1583 already changes. Open design questions (separator, already-prefixed names, lineage, opt-out, removal release) need maintainer decisions before any patch. Done means the unit prefix rule and the MySQL and PostgreSQL integration tests pass, and the docs follow-up is written.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
What happens now
When several projects share one database server, each project needs its own set of schemas: two pipelines that both declare dj.Schema("subject") must not write to the same tables, and an administrator wants to grant a project's users access to that project's schemas only.
-
PostgreSQL:
database.name(DJ_DATABASE_NAME) selects the database. Each project gets its own database, the pipeline writesdj.Schema("subject"), and the projects stay apart. -
MySQL:
database.nameis ignored, with the warning "database.name is set but the MySQL backend does not support database selection". The only way to separate projects is to put a prefix into every schema name in pipeline code:prefix = os.environ["MY_PREFIX"] # or dj.config.database.database_prefix subject = dj.Schema(prefix + "subject") session = dj.Schema(prefix + "session") -
database.database_prefix(DJ_DATABASE_PREFIX): it stores the value but DataJoint never applies it. It is deprecated with the message "will be removed in DataJoint 2.3. Use database.name to select a PostgreSQL database instead". That message is stale on 2.3.x, and it gives MySQL users no replacement.
So the same pipeline is written differently for the two backends. Every MySQL pipeline carries its own prefix handling, and a published example that writes dj.Schema("subject") can't be dropped into a shared MySQL server unchanged.
Proposal
Make database.name the connection's schema namespace on both backends:
| Backend | database.name = "lab_project" |
dj.Schema("subject") on the server |
|---|---|---|
| PostgreSQL | connects to database lab_project (unchanged) |
schema subject in database lab_project |
| MySQL | prefix lab_project_ |
schema lab_project_subject |
- Prefixing.
Schemaadds the prefix itself, so pipelines write plain schema names on both backends. This also coversVirtualModule,virtual_schemaandSchema.activate. schema.database. It is the name on the server (lab_project_subject), as it is today for any schema.dj.list_schemas(). It lists the namespace's schemas under their plain names (subject), so every name it returns can be passed back todj.Schema. A connection withoutdatabase.namestill lists every schema it can see.- Grants. Access is granted by pattern on MySQL (
GRANT ... ON \lab_project_%`.*`) and by database on PostgreSQL. - Already-prefixed names. A name that already starts with the prefix is used as is, with a warning ("write
subjectinstead"). Code that still prefixes by hand keeps reaching the same schemas rather than silently creatinglab_project_lab_project_subject. database_prefix. It stays deprecated and unapplied. Its message points todatabase.name, and the "removed in 2.3" text goes.
Compatibility. A MySQL user who sets database.name today gets a warning and no effect. After this change, their schema names gain the prefix: for example, an environment that sets DJ_DATABASE_NAME for a PostgreSQL database and is reused against MySQL. That is a behaviour change, so it belongs in a minor release, with a note in the release notes.
Migration for a MySQL deployment that prefixes by hand with myproject_: set database.name = "myproject", then drop the prefix from the pipeline's dj.Schema(...) calls. The schemas on the server do not change.
Questions to settle
- Separator. The proposal adds
_itself (name + "_"). The alternative is to take the prefix verbatim, asdatabase_prefixdid. Adding_keepsdatabase.namea name rather than a fragment, and matches the commonproject_convention. - Already-prefixed names. Should they be used as is with a warning, or raise an error? A warning makes migration safe. The cost is one edge case: with namespace
lab, a schema meant to be namedlab_sessionresolves tolab_sessionrather thanlab_lab_session. - Lineage. Lineage strings embed the schema's server name (
schema.table.attribute). On MySQL the prefix becomes part of them; on PostgreSQL the database name does not. Restoring a namespace under a different name then needsschema.rebuild_lineage()on MySQL only. Should lineage record the plain name instead? - Reaching outside the namespace. On PostgreSQL a connection cannot reach another database. On MySQL the prefix confines
dj.Schemato the namespace. A shared reference schema outside it would need either a second connection withoutdatabase.nameor an explicit opt-out (e.g.dj.Schema(name, namespace=False)). The proposal leaves the opt-out out of the first version. - Removing
database_prefix. In which release?
Implementation
The behaviour above is implemented and tested in the linked PR:
Connection.schema_prefixandConnection.qualify_schema_name;Schema.activateapplies the prefix, andlist_schemasfilters and strips it;- the MySQL warning is removed and the deprecation message updated.
Tests:
- Unit: the prefix rule on both backends.
- Integration (MySQL and PostgreSQL): two namespaces each hold a
subjectschema with separate contents;list_schemasreturns plain names;VirtualModuleresolves inside the namespace; an already-prefixed name is not prefixed twice. - Results: unit 457 passed; integration 694 passed, 16 skipped, both backends.
Related: #1426 (added database.name for PostgreSQL and deprecated database_prefix), #1351 (renamed schema_prefix to database_prefix).
Docs follow-up: how-to/configure-database.md, how-to/deploy-production.md §Use Database Prefixes, reference/configuration.md.
- Linguagem predominante
- Python
- Estrelas
- 197
- Forks
- 98
- Merge médio
- 15h 31min
- PRs com merge (30d)
- 9
Preparar o ambiente
- Inclui um Dockerfile ou arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de datajoint/datajoint-python
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
datajoint/datajoint-python#1581 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
datajoint/datajoint-python#1539 · 3 comentários ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 40/100
datajoint/datajoint-python#1580 ·
Mantenedores costumam responder em até 1 dia
-
A column copied by a foreign key loses the parent's core type (int32 becomes int)Talvez já em andamento @dimitri-yatsenko assumiu há 3 dias. Aberta
Dificuldade 3/5 Meio dia Facilidade para iniciantes 25/100
datajoint/datajoint-python#1578 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 3/5 Meio dia Facilidade para iniciantes 65/100
datajoint/datajoint-python#1577 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de datajoint/datajoint-python
Issues semelhantes
-
Consolidate the now-identical CLI-native and composed tasks_packages guards (#5945 follow-up)Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
spec-kitty/spec-kitty#6112 ·
Mantenedores costumam responder em até 1 dia
-
[Bug]: OpenRouter streaming chunks report the requested router name instead of the model OpenRouter servedTalvez já em andamento @Mrun25 assumiu hoje. Abertabug llm translation
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
BerriAI/litellm#46095 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
uberdeveloper/fastbt#29 ·
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
andrew-blake/melcloudhome#368 ·
Mantenedores costumam responder em até 1 dia
-
lane:discover
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
SPARDiffData/differential-data-collection#33 ·
Mantenedores costumam responder em até 1 dia