database.name should namespace schema names on MySQL, as it does on PostgreSQL
維護者通常 1 天內回覆
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 15/100
研究方向
Start with Connection.schema_prefix and Connection.qualify_schema_name, then Schema.activate, list_schemas and the MySQL database.name warning, which the linked PR #1583 already changes. Open design questions (separator, already-prefixed names, lineage, opt-out, removal release) need maintainer decisions before any patch. Done means the unit prefix rule and the MySQL and PostgreSQL integration tests pass, and the docs follow-up is written.
由索引模型根據 Issue 內容生成。
描述
What happens now
When several projects share one database server, each project needs its own set of schemas: two pipelines that both declare dj.Schema("subject") must not write to the same tables, and an administrator wants to grant a project's users access to that project's schemas only.
-
PostgreSQL:
database.name(DJ_DATABASE_NAME) selects the database. Each project gets its own database, the pipeline writesdj.Schema("subject"), and the projects stay apart. -
MySQL:
database.nameis ignored, with the warning "database.name is set but the MySQL backend does not support database selection". The only way to separate projects is to put a prefix into every schema name in pipeline code:prefix = os.environ["MY_PREFIX"] # or dj.config.database.database_prefix subject = dj.Schema(prefix + "subject") session = dj.Schema(prefix + "session") -
database.database_prefix(DJ_DATABASE_PREFIX): it stores the value but DataJoint never applies it. It is deprecated with the message "will be removed in DataJoint 2.3. Use database.name to select a PostgreSQL database instead". That message is stale on 2.3.x, and it gives MySQL users no replacement.
So the same pipeline is written differently for the two backends. Every MySQL pipeline carries its own prefix handling, and a published example that writes dj.Schema("subject") can't be dropped into a shared MySQL server unchanged.
Proposal
Make database.name the connection's schema namespace on both backends:
| Backend | database.name = "lab_project" |
dj.Schema("subject") on the server |
|---|---|---|
| PostgreSQL | connects to database lab_project (unchanged) |
schema subject in database lab_project |
| MySQL | prefix lab_project_ |
schema lab_project_subject |
- Prefixing.
Schemaadds the prefix itself, so pipelines write plain schema names on both backends. This also coversVirtualModule,virtual_schemaandSchema.activate. schema.database. It is the name on the server (lab_project_subject), as it is today for any schema.dj.list_schemas(). It lists the namespace's schemas under their plain names (subject), so every name it returns can be passed back todj.Schema. A connection withoutdatabase.namestill lists every schema it can see.- Grants. Access is granted by pattern on MySQL (
GRANT ... ON \lab_project_%`.*`) and by database on PostgreSQL. - Already-prefixed names. A name that already starts with the prefix is used as is, with a warning ("write
subjectinstead"). Code that still prefixes by hand keeps reaching the same schemas rather than silently creatinglab_project_lab_project_subject. database_prefix. It stays deprecated and unapplied. Its message points todatabase.name, and the "removed in 2.3" text goes.
Compatibility. A MySQL user who sets database.name today gets a warning and no effect. After this change, their schema names gain the prefix: for example, an environment that sets DJ_DATABASE_NAME for a PostgreSQL database and is reused against MySQL. That is a behaviour change, so it belongs in a minor release, with a note in the release notes.
Migration for a MySQL deployment that prefixes by hand with myproject_: set database.name = "myproject", then drop the prefix from the pipeline's dj.Schema(...) calls. The schemas on the server do not change.
Questions to settle
- Separator. The proposal adds
_itself (name + "_"). The alternative is to take the prefix verbatim, asdatabase_prefixdid. Adding_keepsdatabase.namea name rather than a fragment, and matches the commonproject_convention. - Already-prefixed names. Should they be used as is with a warning, or raise an error? A warning makes migration safe. The cost is one edge case: with namespace
lab, a schema meant to be namedlab_sessionresolves tolab_sessionrather thanlab_lab_session. - Lineage. Lineage strings embed the schema's server name (
schema.table.attribute). On MySQL the prefix becomes part of them; on PostgreSQL the database name does not. Restoring a namespace under a different name then needsschema.rebuild_lineage()on MySQL only. Should lineage record the plain name instead? - Reaching outside the namespace. On PostgreSQL a connection cannot reach another database. On MySQL the prefix confines
dj.Schemato the namespace. A shared reference schema outside it would need either a second connection withoutdatabase.nameor an explicit opt-out (e.g.dj.Schema(name, namespace=False)). The proposal leaves the opt-out out of the first version. - Removing
database_prefix. In which release?
Implementation
The behaviour above is implemented and tested in the linked PR:
Connection.schema_prefixandConnection.qualify_schema_name;Schema.activateapplies the prefix, andlist_schemasfilters and strips it;- the MySQL warning is removed and the deprecation message updated.
Tests:
- Unit: the prefix rule on both backends.
- Integration (MySQL and PostgreSQL): two namespaces each hold a
subjectschema with separate contents;list_schemasreturns plain names;VirtualModuleresolves inside the namespace; an already-prefixed name is not prefixed twice. - Results: unit 457 passed; integration 694 passed, 16 skipped, both backends.
Related: #1426 (added database.name for PostgreSQL and deprecated database_prefix), #1351 (renamed schema_prefix to database_prefix).
Docs follow-up: how-to/configure-database.md, how-to/deploy-production.md §Use Database Prefixes, reference/configuration.md.
- 主要語言
- Python
- 星號
- 197
- 分支
- 99
- 平均合併
- 1 天 11 小時
- 30 天內合併 PR
- 10
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
datajoint/datajoint-python 的其他 Issue
-
MySQL error 1143 (column-level SELECT denied) is not translated to AccessError可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉bug
難度 2/5 1-3 小時 新手友好度 85/100
datajoint/datajoint-python#1586 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 70/100
datajoint/datajoint-python#1581 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
datajoint/datajoint-python#1539 · 3 則留言 ·
維護者通常 1 天內回覆
-
Environment variables lose to datajoint.json for settings missing from ENV_VAR_MAPPING可能已有人在做 @dimitri-yatsenko 於 1 天前認領。 未關閉
datajoint/datajoint-python#1585 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
_job_start_time records the populating host's local time, with no zone可能已有人在做 @dimitri-yatsenko 於 2 天前認領。 未關閉
datajoint/datajoint-python#1584 · 已指派 1 人 ·
維護者通常 1 天內回覆
查看 datajoint/datajoint-python 的全部 Issue
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 72/100
-
[Bug]: Importing weave changes the process-wide locale可能已有人在做 @himanshu748 今天認領。 未關閉bug
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
-
bug
難度 2/5 1-3 小時 新手友好度 74/100
-
UX
難度 1/5 1 小時以內 新手友好度 72/100
mediajunkie/piper-morgan-product#2008 · 2 則留言 ·