[coverage] Conformance findings: CLOUDFETCH-018
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
从 tests/ 下 coverage PR 中的 TestLinkFetchFailureSurfacesATerminalError 开始，然后复现带有持久性 link-fetch 失败的多块 CloudFetch 场景。跟踪 Go 驱动程序的 CloudFetch 失败和 drain 路径。完成的标准是：第一次 drain 在 180 秒内引发错误，重复 drain 在 30 秒内返回，并且协议确认发生过一次 chunk fetch。
由索引模型根据 Issue 内容生成。
描述
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.
Findings
- CLOUDFETCH-018 [sea]: A permanently-failing CloudFetch link fetch (403 on GET .../result/chunks/{n}) never returns: after 32 attempts the failure is logged and a waiter woken, but it is never recorded as terminal provider state and end-of-stream is left unset, so the drain blocks past 180s with 0 rows instead of raising a terminal error (kernel #319; the pure-Go Thrift path conforms, giving up in 35s after 5 attempts)
- failing test:
TestLinkFetchFailureSurfacesATerminalError(see the coverage PR diff undertests/)
- failing test:
Reproduce & Expected
CLOUDFETCH-018 — A permanently-failing CloudFetch LINK FETCH must surface a TERMINAL error to the consumer, and must do so in bounded time.
Reproduce:
- Enable this run's protocol scenario (see protocol_scenarios above) so the
link-fetch call fails persistently. The result must be large enough to span
MULTIPLE chunks, so the driver has to ask for links it does not already hold --
otherwise every link arrives inline, no link fetch is issued, and the injected
failure never fires (the protocol guard below catches that vacuous case). - Drain a multi-chunk CloudFetch result whose link fetch fails permanently.
Expect the drain to raise -- not to block, and not to report a clean
end-of-stream over a truncated row set. - Fetch again on the SAME result after the terminal error. Must return promptly
(end-of-stream or the same error), not hang.
Expected (per the shared spec):
- full assertion contract:
result:
- label: first_drain
exception_thrown: true
- label: first_drain
elapsed_seconds_range:
max: 180
- label: repeat_drain
either_condition_true:
- row_count: 0
- exception_thrown: true
- label: repeat_drain
elapsed_seconds_range:
max: 30
protocol:
thrift:
- label: first_drain
call_min:
method: FetchResults
min: 1
sea:
- label: first_drain
call_min:
operation: FetchResultChunk
min: 1
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-sql-kernel/pull/322 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-go; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1571
- 主要语言
- Go
- 星标
- 53
- 派生
- 68
- 平均合并
- 2 天 1 小时
- 30 天内合并 PR
- 8
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
databricks/databricks-sql-go 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
databricks/databricks-sql-go#494 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 48/100
databricks/databricks-sql-go#499 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 64/100
databricks/databricks-sql-go#490 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
databricks/databricks-sql-go#481 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 52/100
databricks/databricks-sql-go#480 ·
维护者通常 1 天内回复
查看 databricks/databricks-sql-go 的全部 Issue
相似的 Issue
-
agent-review-finding chore
难度 2/5 1-3 小时 新手友好度 73/100
jordansmall/spindrift#5748 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 74/100
-
Resource links written as host:port without a scheme are broken可能已有人在做 @RaphaelFakhri 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 1 天内回复
-
Proxy ignores l5d-retry-http and l5d-retry-grpc conditions that follow a comma and space可能已有人在做 @RaphaelFakhri 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 83/100
维护者通常 3 天内回复
-
needs_triage
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 2 天内回复