[coverage] Conformance findings: STATEMENT-025
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with TestQueryTimeoutOptionValueValidation in the coverage PR under tests, then trace the DSN timeout and dbsql.WithTimeout paths for both the Thrift and SEA/kernel backends. Compare their handling of negative values with the shared assertion contract and the reference PR. Done means invalid negative values are rejected with an error naming timeout while valid zero, positive, and maximum values retain the expected behavior.
由索引模型根据 Issue 内容生成。
描述
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.
Findings
- STATEMENT-025 [thrift]: Negative query-timeout is silently accepted: DSN
timeout=-1and dbsql.WithTimeout(-1s) both configure fine and the query runs with the invalid deadline, while non-numeric and out-of-range values ARE rejected with the option named — the value is parsed but not range-validated (PECO-3011).- failing test:
TestQueryTimeoutOptionValueValidation(see the coverage PR diff undertests/)
- failing test:
- STATEMENT-025 [sea]: Same negative-value gap on the SEA/kernel leg, and sharper: the kernel backend REFUSES any non-zero dbsql.WithTimeout up front ("not supported by the kernel backend") yet still ACCEPTS WithTimeout(-1s) and DSN timeout=-1 and runs the query — positive refused, negative waved through (PECO-3011).
- failing test:
TestQueryTimeoutOptionValueValidation(see the coverage PR diff undertests/)
- failing test:
- STATEMENT-025: Negative query-timeout values are silently accepted instead of rejected:
timeout=-1in the DSN and dbsql.WithTimeout(-1s) both configure successfully and a query then runs with the invalid deadline (behaving as "unlimited"), while non-numeric and out-of-range values ARE correctly rejected with a message naming the option — proving the value is parsed but not range-validated (PECO-3011). Affects both the Thrift and SEA/kernel backends; notably the kernel backend refuses any non-zero WithTimeout up front yet still accepts a negative one.
Reproduce & Expected
STATEMENT-025 — Validates that an INVALID value for the query-timeout option is REJECTED with an error at configuration time, on every surface that accepts the option, instead of being silently accepted and coerced…
Reproduce:
SELECT 1
SELECT 1
Expected (per the shared spec):
- completes without an exception
- result has exactly 1 row(s)
- completes without an exception
- result has exactly 1 row(s)
- completes without an exception
- completes without an exception
- completes without an exception
- full assertion contract:
result:
- label: property_non_numeric
error:
contains:
- timeout
- label: property_negative
error:
contains:
- timeout
- label: property_unrepresentable
error:
contains:
- timeout
- label: set_option_non_numeric
error:
contains:
- timeout
- label: set_option_negative
error:
contains:
- timeout
- label: set_option_unrepresentable
error:
contains:
- timeout
- label: property_zero_unlimited
no_exception: true
- label: property_zero_unlimited
row_count: 1
- label: property_max_positive
no_exception: true
- label: property_max_positive
row_count: 1
- label: set_option_valid_zero
no_exception: true
- label: set_option_valid_one
no_exception: true
- label: set_option_valid_max
no_exception: true
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/adbc-drivers/databricks/pull/689 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-go; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1692
- 主要语言
- Go
- 星标
- 53
- 派生
- 66
- 平均合并
- 21 小时 29 分钟
- 30 天内合并 PR
- 12
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
databricks/databricks-sql-go 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
databricks/databricks-sql-go#476 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
databricks/databricks-sql-go#481 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 52/100
databricks/databricks-sql-go#480 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
databricks/databricks-sql-go#475 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 65/100
databricks/databricks-sql-go#474 ·
维护者通常 1 天内回复
查看 databricks/databricks-sql-go 的全部 Issue
相似的 Issue
-
Remove CAAPF未关闭kind/chore kind/cleanup needs-area
难度 2/5 1-3 小时 新手友好度 86/100
rancher/turtles#2848 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
good first issue
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
priority: low 🌱 type: enhancement 💅🏼
难度 2/5 半天 新手友好度 84/100
nebari-dev/llm-serving-pack#199 ·
维护者通常 3 天内回复
-
难度 1/5 1 小时以内 新手友好度 90/100
维护者通常 1 天内回复