[coverage] Conformance findings: CLOUDFETCH-019
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
先从 tests/ 下 coverage PR diff 中的 TestInvalidClientSideCloudFetchKnobValueDoesNotFailSessionOpen 开始,然后跟踪 Go CloudFetch 选项处理和 session request 路径。针对 databricks-sql-go 运行测试,并确认无效值和超过最大值的值至少生成一行,使相关 protocol request 字段保持缺失,并满足 download assertions。
由索引模型根据 Issue 内容生成。
描述
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.
Findings
- CLOUDFETCH-019 [thrift]: A non-positive client-side CloudFetch knob value (WithMaxDownloadThreads(-1)) is not validated: session open and execution succeed but the download worker pool starts no workers, so no Arrow batch is produced and the first row read fails with "row number 0 is not contained in any arrow batch: EOF" instead of degrading to the driver default (the above-maximum shape conforms).
- failing test:
TestInvalidClientSideCloudFetchKnobValueDoesNotFailSessionOpen(see the coverage PR diff undertests/)
- failing test:
- CLOUDFETCH-019: A non-positive client-side CloudFetch knob value (WithMaxDownloadThreads(-1)) is not validated: session open and execution succeed but the download worker pool starts no workers, so the result stream produces no Arrow batch and the first row read fails with "row number 0 is not contained in any arrow batch: EOF" instead of degrading to the driver default (databricks-odbc#227 pre-screens and warns).
Reproduce & Expected
CLOUDFETCH-019 — A bad value for a client-side CloudFetch tuning knob must degrade to the driver default, never fail the connection.
Reproduce:
- Same knob as CLOUDFETCH-018 (this driver's client-side CloudFetch knob), set
to a value that is not a positive integer — e.g.
adbc.databricks.cloudfetch.max_chunks_in_memory = "not-a-number". Use "0" or
"-1" where the driver's option surface is typed and cannot carry a
non-numeric string. - The same knob set far above any plausible ceiling — e.g. "100000" (the
reference kernel clamps at 256).
Expected (per the shared spec):
- completes without an exception
- result has at least 1 row(s)
- completes without an exception
- result has at least 1 row(s)
- [thrift]
OpenSessionrequestconfiguration.cloudfetch_max_chunks_in_memoryis absent - [sea]
CreateSessionrequestsession_confs.cloudfetch_max_chunks_in_memoryis absent - full assertion contract:
result:
- label: not_a_positive_integer
no_exception: true
- label: not_a_positive_integer
row_count_min: 1
- label: above_maximum
no_exception: true
- label: above_maximum
row_count_min: 1
protocol:
thrift:
- label: not_a_positive_integer
request_field:
method: OpenSession
path: configuration.cloudfetch_max_chunks_in_memory
present: false
- label: not_a_positive_integer
cloud_downloads_min: 1
sea:
- label: not_a_positive_integer
request_field:
operation: CreateSession
path: session_confs.cloudfetch_max_chunks_in_memory
present: false
- label: not_a_positive_integer
cloud_downloads_min: 1
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-odbc/pull/231 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-go; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1242
- 主要语言
- Go
- 星标
- 53
- 派生
- 68
- 平均合并
- 2 天 1 小时
- 30 天内合并 PR
- 8
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
databricks/databricks-sql-go 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
databricks/databricks-sql-go#494 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 48/100
databricks/databricks-sql-go#499 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 64/100
databricks/databricks-sql-go#490 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
databricks/databricks-sql-go#481 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 52/100
databricks/databricks-sql-go#480 ·
维护者通常 1 天内回复
查看 databricks/databricks-sql-go 的全部 Issue
相似的 Issue
-
area/import kind/bug
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
kind/documentation
难度 2/5 1-3 小时 新手友好度 80/100
kubernetes-sigs/dra-driver-nvidia-gpu#1569 ·
维护者通常 1 天内回复
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
难度 2/5 1-3 小时 新手友好度 65/100
openclaw/openclaw-enterprise#2571 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复