[coverage] Conformance findings: CLOUDFETCH-019
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 62/100
Direzione di ricerca
Inizia con TestInvalidClientSideCloudFetchKnobValueDoesNotFailSessionOpen nel diff della PR di coverage sotto tests/, quindi segui la gestione dell’opzione Go CloudFetch e il percorso della richiesta di sessione. Esegui il test con databricks-sql-go e conferma che i valori non validi e quelli superiori al massimo producano almeno una riga, lascino assente il campo rilevante della richiesta di protocollo e soddisfino le asserzioni di download.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-go. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-go) is fixed, then flips green as a tripwire.
Findings
- CLOUDFETCH-019 [thrift]: A non-positive client-side CloudFetch knob value (WithMaxDownloadThreads(-1)) is not validated: session open and execution succeed but the download worker pool starts no workers, so no Arrow batch is produced and the first row read fails with "row number 0 is not contained in any arrow batch: EOF" instead of degrading to the driver default (the above-maximum shape conforms).
- failing test:
TestInvalidClientSideCloudFetchKnobValueDoesNotFailSessionOpen(see the coverage PR diff undertests/)
- failing test:
- CLOUDFETCH-019: A non-positive client-side CloudFetch knob value (WithMaxDownloadThreads(-1)) is not validated: session open and execution succeed but the download worker pool starts no workers, so the result stream produces no Arrow batch and the first row read fails with "row number 0 is not contained in any arrow batch: EOF" instead of degrading to the driver default (databricks-odbc#227 pre-screens and warns).
Reproduce & Expected
CLOUDFETCH-019 — A bad value for a client-side CloudFetch tuning knob must degrade to the driver default, never fail the connection.
Reproduce:
- Same knob as CLOUDFETCH-018 (this driver's client-side CloudFetch knob), set
to a value that is not a positive integer — e.g.
adbc.databricks.cloudfetch.max_chunks_in_memory = "not-a-number". Use "0" or
"-1" where the driver's option surface is typed and cannot carry a
non-numeric string. - The same knob set far above any plausible ceiling — e.g. "100000" (the
reference kernel clamps at 256).
Expected (per the shared spec):
- completes without an exception
- result has at least 1 row(s)
- completes without an exception
- result has at least 1 row(s)
- [thrift]
OpenSessionrequestconfiguration.cloudfetch_max_chunks_in_memoryis absent - [sea]
CreateSessionrequestsession_confs.cloudfetch_max_chunks_in_memoryis absent - full assertion contract:
result:
- label: not_a_positive_integer
no_exception: true
- label: not_a_positive_integer
row_count_min: 1
- label: above_maximum
no_exception: true
- label: above_maximum
row_count_min: 1
protocol:
thrift:
- label: not_a_positive_integer
request_field:
method: OpenSession
path: configuration.cloudfetch_max_chunks_in_memory
present: false
- label: not_a_positive_integer
cloud_downloads_min: 1
sea:
- label: not_a_positive_integer
request_field:
operation: CreateSession
path: session_confs.cloudfetch_max_chunks_in_memory
present: false
- label: not_a_positive_integer
cloud_downloads_min: 1
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-odbc/pull/231 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-go; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1242
- Lingua principale
- Go
- Stelle
- 53
- Fork
- 66
- Merge medio
- 7h 57m
- PR unite (30g)
- 16
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di databricks/databricks-sql-go
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
databricks/databricks-sql-go#476 ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
databricks/databricks-sql-go#481 ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100
databricks/databricks-sql-go#480 ·
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
databricks/databricks-sql-go#475 · 1 commento ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 65/100
databricks/databricks-sql-go#474 ·
Tutte le issue di databricks/databricks-sql-go
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
acceptance-tests phase-coding schema-coverage testing triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100