Animation keys follow-ups from the #364 review: Redo docs, sourced-scene error codes, test temp path

未关闭
  • 哪里不对？
#397 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@calmasacow 已经在做这个了。

开始于 2026年11月8日。

  • #408 来自 @calmasacow —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
52/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust
领域
desktop, documentation, testing

调研方向

Read .project-docs/mcp.md and the Undo/Redo arm in src/app/dispatch.rs to understand the documented refusal behavior. Compare the error codes for key commands and session-material commands on opened .mb scenes, then inspect the SDK tests and src/app/features/timeline/tests.rs. Done means the Redo row documents the refusal, both command slices use one tested error convention, and the temp-path test uses a unique directory.

由索引模型根据 Issue 内容生成。

描述

priority/p3 type/chore urgency/this-quarter

Follow-ups from claude-fleet's full review of #364 (session-only animation keys) at b06cf39. All are low or info.

  1. Redo row in mcp.md. .project-docs/mcp.md explains, in the Undo row only, that a pose re-evaluation refusal after the step still answers changed, with the refusal in inspect_scene status_message. Redo takes the same path (src/app/dispatch.rs, Undo/Redo arm), so add the same sentence to the Redo row.
  2. Error codes for opened .mb scenes disagree between slices. Key commands on an opened Maya Binary return scene_error, while session-material commands on the same scene return unsupported_edit. Both are documented, but a client sees two codes for the same "sourced scene" refusal. Pick one convention and align both slices, with SDK tests.
  3. Fixed temp path in a test. src/app/features/timeline/tests.rs saves to a fixed temp_dir() path and asserts that it doesn't exist. Use a unique tempdir (tempfile), so parallel runs or leftovers can't make it flaky.

Refs #361, #364

主要语言
Rust
星标
4
派生
2
平均合并
1 天 5 分钟
30 天内合并 PR
213

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

cristim/AztecCraft 的其他 Issue

查看 cristim/AztecCraft 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。