Animation keys follow-ups from the #364 review: Redo docs, sourced-scene error codes, test temp path

Abierto
#397 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
52/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust

Línea de trabajo

Read .project-docs/mcp.md and the Undo/Redo arm in src/app/dispatch.rs to understand the documented refusal behavior. Compare the error codes for key commands and session-material commands on opened .mb scenes, then inspect the SDK tests and src/app/features/timeline/tests.rs. Done means the Redo row documents the refusal, both command slices use one tested error convention, and the temp-path test uses a unique directory.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

priority/p3 type/chore urgency/this-quarter

Follow-ups from claude-fleet's full review of #364 (session-only animation keys) at b06cf39. All are low or info.

  1. Redo row in mcp.md. .project-docs/mcp.md explains, in the Undo row only, that a pose re-evaluation refusal after the step still answers changed, with the refusal in inspect_scene status_message. Redo takes the same path (src/app/dispatch.rs, Undo/Redo arm), so add the same sentence to the Redo row.
  2. Error codes for opened .mb scenes disagree between slices. Key commands on an opened Maya Binary return scene_error, while session-material commands on the same scene return unsupported_edit. Both are documented, but a client sees two codes for the same "sourced scene" refusal. Pick one convention and align both slices, with SDK tests.
  3. Fixed temp path in a test. src/app/features/timeline/tests.rs saves to a fixed temp_dir() path and asserts that it doesn't exist. Use a unique tempdir (tempfile), so parallel runs or leftovers can't make it flaky.

Refs #361, #364

Lenguaje dominante
Rust
Estrellas
4
Forks
2
Merge medio
1 d 5 min
PR fusionados (30 d)
213

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de cristim/AztecCraft

Todos los issues de cristim/AztecCraft

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.