Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Remove interaction readiness result forwarding left after the readiness-wait removal

未关闭
#3,607 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
40/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
tooling

调研方向

Start from packages/daemon/src/execution/interaction/internal/interaction-touch-response.ts and packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts, removing the 'readiness' in result copy and the 'readiness' entry in SAFE_CAUSE_DETAIL_KEYS. Then update interaction-touch-response.test.ts and session-replay-runtime-failure-response.test.ts as the issue lists. Do not start until #3599 is merged, since these sites only become unreachable after it lands. Done when the git grep -n -w readiness check on the two directories returns no hits and pnpm check:affected --base origin/main --run passes.

由索引模型根据 Issue 内容生成。

描述

on-hold refactor

Purpose

#3599 removes the replay target-readiness wait, which was the only producer of an interaction readiness result ({ polls, waitedMs, end }). Two consumers still forward that field, and their tests still build the old shape. Delete them so no code describes a field that can no longer exist.

Blocked by: #3599 (merge first; these sites are unreachable only after it lands).

Required change

  • packages/daemon/src/execution/interaction/internal/interaction-touch-response.ts: drop the 'readiness' in result copy into responseData.
  • packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts: drop 'readiness' from SAFE_CAUSE_DETAIL_KEYS.
  • Tests: in interaction-touch-response.test.ts, remove the readiness-shaped selectorResult fixture and the two readiness assertions, keeping the prior-warning assertion. In session-replay-runtime-failure-response.test.ts, remove "a replay divergence carries the readiness evidence of an exhausted target wait".

Done when

  • git grep -n -w readiness -- packages/daemon/src/execution/interaction packages/replay-port/src/daemon-port returns no interaction-result or replay-cause hits.
  • pnpm check:affected --base origin/main --run passes.
  • No behavior change: nothing produces the field after #3599.
主要语言
TypeScript
星标
5k
派生
334
平均合并
13 小时 19 分钟
30 天内合并 PR
630

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

callstack/agent-device 的其他 Issue

查看 callstack/agent-device 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。