Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Remove interaction readiness result forwarding left after the readiness-wait removal

Chiusa
  • Qualcosa non va?
#3,607 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
40/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
tooling

Direzione di ricerca

Start from packages/daemon/src/execution/interaction/internal/interaction-touch-response.ts and packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts, removing the 'readiness' in result copy and the 'readiness' entry in SAFE_CAUSE_DETAIL_KEYS. Then update interaction-touch-response.test.ts and session-replay-runtime-failure-response.test.ts as the issue lists. Do not start until #3599 is merged, since these sites only become unreachable after it lands. Done when the git grep -n -w readiness check on the two directories returns no hits and pnpm check:affected --base origin/main --run passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

on-hold refactor

Purpose

#3599 removes the replay target-readiness wait, which was the only producer of an interaction readiness result ({ polls, waitedMs, end }). Two consumers still forward that field, and their tests still build the old shape. Delete them so no code describes a field that can no longer exist.

Blocked by: #3599 (merge first; these sites are unreachable only after it lands).

Required change

  • packages/daemon/src/execution/interaction/internal/interaction-touch-response.ts: drop the 'readiness' in result copy into responseData.
  • packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts: drop 'readiness' from SAFE_CAUSE_DETAIL_KEYS.
  • Tests: in interaction-touch-response.test.ts, remove the readiness-shaped selectorResult fixture and the two readiness assertions, keeping the prior-warning assertion. In session-replay-runtime-failure-response.test.ts, remove "a replay divergence carries the readiness evidence of an exhausted target wait".

Done when

  • git grep -n -w readiness -- packages/daemon/src/execution/interaction packages/replay-port/src/daemon-port returns no interaction-result or replay-cause hits.
  • pnpm check:affected --base origin/main --run passes.
  • No behavior change: nothing produces the field after #3599.
Lingua principale
TypeScript
Stelle
5k
Fork
334
Merge medio
12h 2m
PR unite (30g)
678

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di callstack/agent-device

Tutte le issue di callstack/agent-device

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.