Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Remove interaction readiness result forwarding left after the readiness-wait removal

Fechada
  • Algo errado?
#3,607 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
40/100
Tipo de issue
Refatoração
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
tooling

Direção de pesquisa

Start from packages/daemon/src/execution/interaction/internal/interaction-touch-response.ts and packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts, removing the 'readiness' in result copy and the 'readiness' entry in SAFE_CAUSE_DETAIL_KEYS. Then update interaction-touch-response.test.ts and session-replay-runtime-failure-response.test.ts as the issue lists. Do not start until #3599 is merged, since these sites only become unreachable after it lands. Done when the git grep -n -w readiness check on the two directories returns no hits and pnpm check:affected --base origin/main --run passes.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

on-hold refactor

Purpose

#3599 removes the replay target-readiness wait, which was the only producer of an interaction readiness result ({ polls, waitedMs, end }). Two consumers still forward that field, and their tests still build the old shape. Delete them so no code describes a field that can no longer exist.

Blocked by: #3599 (merge first; these sites are unreachable only after it lands).

Required change

  • packages/daemon/src/execution/interaction/internal/interaction-touch-response.ts: drop the 'readiness' in result copy into responseData.
  • packages/replay-port/src/daemon-port/session-replay-runtime-failure-response.ts: drop 'readiness' from SAFE_CAUSE_DETAIL_KEYS.
  • Tests: in interaction-touch-response.test.ts, remove the readiness-shaped selectorResult fixture and the two readiness assertions, keeping the prior-warning assertion. In session-replay-runtime-failure-response.test.ts, remove "a replay divergence carries the readiness evidence of an exhausted target wait".

Done when

  • git grep -n -w readiness -- packages/daemon/src/execution/interaction packages/replay-port/src/daemon-port returns no interaction-result or replay-cause hits.
  • pnpm check:affected --base origin/main --run passes.
  • No behavior change: nothing produces the field after #3599.
Linguagem predominante
TypeScript
Estrelas
5k
Forks
334
Merge médio
12h 29min
PRs com merge (30d)
663

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de callstack/agent-device

Todas as issues de callstack/agent-device

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.