[Feature] Bypass manifest lists on exact snapshot live-entry cache hits

未关闭
#375 0 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
30/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
cpp
领域
databases

调研方向

Start with AppendOnlyFileStoreScanTest.TestSnapshotLiveManifestCachePath and the public orc/append_09.db/append_09 fixture, using snapshot 5 and bucket 0 to reproduce the cache-hit path. Review draft implementation #374 and its focused regression tests for manifest-cache access counts, changed predicates, eviction/rebuild, and retained file counts. Done means eligible exact hits skip manifest reads and decoding while misses rebuild completely and filters, snapshot identity, and metrics remain correct.

由索引模型根据 Issue 内容生成。

描述

Search before asking
  • I searched existing issues and found no report of this exact-hit planning overhead.
Motivation

Repeated scans of the same snapshot and bucket still read and decode the manifest lists before checking the snapshot live-manifest-entry cache. The cached live entries already contain the state needed for that bucket, so this work adds avoidable CPU and metadata access to repeated point-read planning.

To reproduce, use the public orc/append_09.db/append_09 test fixture with snapshot 5 and bucket 0, enable the snapshot live-manifest-entry cache, and reuse one cache across two scans. Instrument the MANIFEST cache accesses, as in AppendOnlyFileStoreScanTest.TestSnapshotLiveManifestCachePath. Before the proposed change, the second scan revisits the manifest-list path even though its exact snapshot/bucket live-entry lookup hits.

Expected: an eligible exact hit bypasses manifest-list reads and decoding, while each request still applies its own filters. A miss must rebuild the complete bucket. Snapshot selection and the existing snapshot-identity validation must remain intact.

Solution

Resolve the snapshot first and consult the existing snapshot live-entry cache before reading manifest lists. Retain the table file count in the transient cached payload so skipped-file metrics remain correct; report zero scanned manifests for an exact hit. Version the transient payload so incompatible entries fall back to rebuilding.

Draft implementation: #374. Regression tests check the manifest-cache access count, changed predicates, eviction/rebuild, and retained file counts. This change does not introduce a filesystem block cache or alter the persisted table format.

Anything else?

The identical patch passed 88 focused tests in a downstream C++17 Release build. Upstream CI for the draft still requires maintainer approval; no standalone end-to-end performance uplift is claimed for this individual optimization.

Are you willing to submit a PR?
  • I am willing to submit a PR; #374 is available as a draft.
主要语言
C++
星标
65
派生
29
平均合并
2 天 30 分钟
30 天内合并 PR
77

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

apache/paimon-cpp 的其他 Issue

查看 apache/paimon-cpp 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。