DuckDB: `f(a == b)` is displayed as `f(a = b)`, which reparses as a named argument

未关闭
  • 哪里不对？
#2,808 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust, sql
领域
databases

调研方向

Start with how BinaryOperator::Eq is displayed, and with the DuckDB dialect's supports_named_fn_args_with_eq_operator flag (#1182) that makes a = b inside a call a named argument. Reproduce SELECT coalesce(a == b) FROM t as a round trip and compare the AST before and after. Before changing anything, check with maintainers whether this counts as accepted normalisation, since the thread has no answer yet. Done means the round trip keeps Unnamed(BinaryOp { a Eq b }), or the maintainers have documented why it does not.

由索引模型根据 Issue 内容生成。

描述

DuckDB Prolific Author

== is parsed as BinaryOperator::Eq and displayed as =. Inside a function call with DuckDbDialect, a = b is a named argument (supports_named_fn_args_with_eq_operator, #1182), so the output means something else:

SELECT coalesce(a == b) FROM t
  -> AST arg: Unnamed(BinaryOp { a Eq b })
  -> displays as: SELECT coalesce(a = b) FROM t
  -> reparse arg: Named { name: a, arg: b, operator: Equals }
SELECT a == b FROM t
  -> displays as SELECT a = b FROM t, same AST (fine)

DuckDB documents = and == as equal (https://duckdb.org/docs/stable/sql/expressions/comparison_operators) and evaluates coalesce(a == b) as a comparison. This may count as accepted normalisation; the only effect is the AST change inside call arguments.

Tested on main ce12f1f6 (also 0.63.0 and 0.58.0).

Found with a property-based fuzzer (round trip check); I used AI assistance for triage and verified every case above.

主要语言
Rust
星标
3.5k
派生
805
平均合并
2 天 3 小时
30 天内合并 PR
116

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

apache/datafusion-sqlparser-rs 的其他 Issue

查看 apache/datafusion-sqlparser-rs 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。