[FEATURE]: Report when a Promise RPC event listener ends

未关闭
#65,381 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
typescript
领域
api

调研方向

Start at packages/client/src/promise/rpc.ts:124-137, where the callback subscription is built and only an unsubscribe function is returned, then trace how the underlying events.subscribe stream signals completion and failure. Read the client subscription documentation linked in the issue to see the documented contract callers rely on. Done means the callback API can report normal completion or a handler error exactly once, treats explicit unsubscribe as cancellation, and keeps sequential handling and per-subscriber cancellation intact, with tests covering each case.

由索引模型根据 Issue 内容生成。

描述

area/sdk-api type/feature version/v2
Feature hasn't been suggested before.
  • I have verified this feature I'm about to request hasn't been suggested before.
Describe the enhancement you want to request

Please let callers observe when client.rpc(contract).events.on(...) stops listening. A status widget using this callback API needs to leave its live state after a server disconnect and let its owner decide when to resubscribe.

Currently it returns only an unsubscribe function. Callback/source failures are logged internally, and normal stream completion has no caller notification. The working alternative is to replace the callback subscription with a supervised events.subscribe(...) loop.

An optional lifecycle callback or completion-bearing subscription handle would make this possible without replacing the callback API:

  • Report normal completion or failure once, including errors thrown by an async handler.
  • Treat explicit unsubscribe/abort as cancellation rather than an unexpected error.
  • Preserve sequential callback handling and cancellation of only that subscriber.

Reconnection and resynchronization would remain caller-controlled. This is an enhancement to the documented behavior, not a report of a user incident. Source: packages/client/src/promise/rpc.ts:124-137; client subscription documentation.

主要语言
TypeScript
星标
227k
派生
30.7k
平均合并
3 小时 57 分钟
30 天内合并 PR
484

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

anomalyco/opencode 的其他 Issue

查看 anomalyco/opencode 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。