[FEATURE]: Report when a Promise RPC event listener ends

Offen
#65,381 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
api

Rechercherichtung

Start at packages/client/src/promise/rpc.ts:124-137, where the callback subscription is built and only an unsubscribe function is returned, then trace how the underlying events.subscribe stream signals completion and failure. Read the client subscription documentation linked in the issue to see the documented contract callers rely on. Done means the callback API can report normal completion or a handler error exactly once, treats explicit unsubscribe as cancellation, and keeps sequential handling and per-subscriber cancellation intact, with tests covering each case.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area/sdk-api type/feature version/v2
Feature hasn't been suggested before.
  • I have verified this feature I'm about to request hasn't been suggested before.
Describe the enhancement you want to request

Please let callers observe when client.rpc(contract).events.on(...) stops listening. A status widget using this callback API needs to leave its live state after a server disconnect and let its owner decide when to resubscribe.

Currently it returns only an unsubscribe function. Callback/source failures are logged internally, and normal stream completion has no caller notification. The working alternative is to replace the callback subscription with a supervised events.subscribe(...) loop.

An optional lifecycle callback or completion-bearing subscription handle would make this possible without replacing the callback API:

  • Report normal completion or failure once, including errors thrown by an async handler.
  • Treat explicit unsubscribe/abort as cancellation rather than an unexpected error.
  • Preserve sequential callback handling and cancellation of only that subscriber.

Reconnection and resynchronization would remain caller-controlled. This is an enhancement to the documented behavior, not a report of a user incident. Source: packages/client/src/promise/rpc.ts:124-137; client subscription documentation.

Vorherrschende Sprache
TypeScript
Sterne
227k
Forks
30.7k
Ø Merge
3 Std. 57 Min.
Gemergte PRs (30 T.)
484

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus anomalyco/opencode

Alle Issues in anomalyco/opencode

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.