Shell tool: no upper bound on the timeout a model can ask for, so one call can hold a turn for hours

未关闭 适合新手
#65,254 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
75/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
tooling

调研方向

阅读 packages/opencode/src/tool/shell.ts 了解 v1 的超时处理,阅读 packages/core/src/tool/bash.ts 了解 MAX_TIMEOUT_MS;对比 v2 路径 packages/core/src/tool/plugin/shell.ts。使用 sleep 3000 和 timeout: 14400000 这类慢命令复现问题,然后把前台超时限制在现有最大值或配置值。完成标准是:过长的超时请求不再超过上限阻塞,同时命令仍会在该边界处转入后台运行。

由索引模型根据 Issue 内容生成。

描述

area/core platform/linux type/feature version/v2
Description

The shell tool takes whatever timeout the model sends. There's no upper bound, so one call can hold the turn for hours.

We run opencode headless for coding agent evals, with a 60 minute limit per run. In four runs the model (Kimi K3 and K3.1 Pro) started a full Gradle test suite with timeout set to 3600000, 7200000 and 14400000 ms. That suite takes about an hour in our environment, so the call never came back and the run got cut at the limit with no answer. Before that call each run had made 44 to 110 tool calls and all of them completed.

The timeout message also tells the model to "retry with a larger timeout value", so it pushes models toward big numbers. In one run the model went from 120 s to 30 minutes on the retry.

In 1.19.6, packages/opencode/src/tool/shell.ts only rejects a negative value and then uses params.timeout ?? defaultTimeoutMs. packages/core/src/tool/bash.ts has MAX_TIMEOUT_MS = 10 * 60 * 1_000 and checks it in its schema, but the shell tool doesn't use it.

From reading dev (fe8def685) a foreground call looks the same: packages/core/src/tool/plugin/shell.ts takes a NonNegativeInt and uses input.timeout || DEFAULT_TIMEOUT_MS. A command that's still running at its timeout moves to the background now, which is the behavior we want, but a model that asks for 4 hours still blocks for 4 hours first.

What I'd like is a maximum for the foreground timeout: 10 minutes like MAX_TIMEOUT_MS, or a setting for it. Past the maximum, move the command to the background on v2 or stop it on v1. For v1, just applying the existing MAX_TIMEOUT_MS in the shell tool would fix it for us.

Related: #63748 asks for a configurable default. This one is about the upper bound.

Plugins

A small internal hooks plugin. It doesn't change the timeout.

OpenCode version

1.19.5 (where we saw it). 1.19.6 and dev fe8def685 from reading the source.

Steps to reproduce
  1. Have the model call the shell tool with a slow command and a long timeout, for example sleep 3000 with timeout: 14400000.
  2. The call blocks until the command ends. Nothing gives the turn back to the model before that.
Screenshot

No response

Operating System

Linux (container)

Terminal

none, headless

主要语言
TypeScript
星标
227k
派生
30.7k
平均合并
3 小时 57 分钟
30 天内合并 PR
484

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

anomalyco/opencode 的其他 Issue

查看 anomalyco/opencode 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。