T27-24 — Verify the remaining PR #8 findings, fix the valid ones, document the rejected ones

未关闭
  • 哪里不对？
#47 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust
领域
backend, testing

调研方向

Start with docs/release/PHASE-0-AUDIT.md §7 and the PR #8 inline comments, then compare each listed finding with the named Rust files and documentation. Run the stated cargo test -p app -p engine verification after addressing valid findings. Done means every Major/Critical finding has a recorded disposition: a fix with a regression test or a written rejection reason.

由索引模型根据 Issue 内容生成。

描述

release

T27 row: T27-24
Work package: RP-00 — Inventory, release contract, baseline, task ledger (Phase-2: PR #8 remediation)
Priority: P1
Status: IN PROGRESS

Objective

Close out every remaining Major/Critical review finding on PR #8 by verifying it against current code, fixing it if valid, and rejecting it with a written reason if not.

Acceptance criteria: Every remaining Major/Critical finding is independently verified against current code; valid ones are fixed with a regression test; rejected ones carry a written reason naming the code that is actually correct.

Inputs

The PR #8 inline comments; the census in docs/release/EXECUTION-BOARD.md §6; crates/app/src/editor.rs; crates/app/src/shell/panels_web.rs; crates/engine/src/catalog/retouch.rs; xtask/src/main.rs; docs/CS6-PARITY.md, docs/NEXT.md, docs/PROGRESS.md, docs/HANDOFF.md, docs/wiki/, README.md.

Authority

The PR #8 reviews; docs/RELEASE-ENGINEERING-PLAN.md §9 (a PR must state unverified gaps explicitly).

Stopping condition

Every enumerated finding has a disposition — fixed with a regression test, or rejected with a reason — and the dispositions are recorded.

Verification

cargo test -p app -p engine

Evidence and blockers

The candidate findings are enumerated in the ticket's evidence line and in docs/release/PHASE-0-AUDIT.md §7: editor.rs:619 (drag_quadrangle moves the wrong corners and its doc comment is inaccurate), editor.rs:2376 (Scale/Skew/Distort read document().object_selection instead of the live selection), editor.rs:2595 (Redraw Path drag must send the sampled pointer trace, not a two-point segment), panels_web.rs:574 (unsupported width/height in symbol.createInstance), panels_web.rs:595 (a second symbol/insert_box payload finding), retouch.rs:656 and retouch.rs:1149 (saturating multiplication for a radius→diameter conversion), xtask/src/main.rs:222 (a Minor finding on the release branch), plus documentation-accuracy findings across docs/CS6-PARITY.md, docs/NEXT.md, docs/PROGRESS.md, docs/research/fw-ui-evidence.md, docs/HANDOFF.md, docs/wiki/ and README.md.

PR #8 remains open. The campaign's P2.4 items covering retrieval, per-finding verification, fixes, written rejections, the full application suite, the CI gate and the web build + browser smoke are all unchecked; a triage pass over the review findings is currently in flight, which is why this row is IN PROGRESS rather than NOT STARTED.

Blocker: none.

Ledger: docs/tasks/T27-24-pr8-remaining-findings.md and docs/release/EXECUTION-BOARD.md row T27-24 (these land with PR #12).
Campaign: docs/planning/release-compaign/Cross-Platform Releas.txt.

主要语言
Rust
星标
11
派生
1
平均合并
9 小时 48 分钟
30 天内合并 PR
13

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

aliasfoxkde/FireCraft 的其他 Issue

查看 aliasfoxkde/FireCraft 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。