T27-24 — Verify the remaining PR #8 findings, fix the valid ones, document the rejected ones

Aperta
  • Qualcosa non va?
#47 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
backend, testing

Direzione di ricerca

Start with docs/release/PHASE-0-AUDIT.md §7 and the PR #8 inline comments, then compare each listed finding with the named Rust files and documentation. Run the stated cargo test -p app -p engine verification after addressing valid findings. Done means every Major/Critical finding has a recorded disposition: a fix with a regression test or a written rejection reason.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

release

T27 row: T27-24
Work package: RP-00 — Inventory, release contract, baseline, task ledger (Phase-2: PR #8 remediation)
Priority: P1
Status: IN PROGRESS

Objective

Close out every remaining Major/Critical review finding on PR #8 by verifying it against current code, fixing it if valid, and rejecting it with a written reason if not.

Acceptance criteria: Every remaining Major/Critical finding is independently verified against current code; valid ones are fixed with a regression test; rejected ones carry a written reason naming the code that is actually correct.

Inputs

The PR #8 inline comments; the census in docs/release/EXECUTION-BOARD.md §6; crates/app/src/editor.rs; crates/app/src/shell/panels_web.rs; crates/engine/src/catalog/retouch.rs; xtask/src/main.rs; docs/CS6-PARITY.md, docs/NEXT.md, docs/PROGRESS.md, docs/HANDOFF.md, docs/wiki/, README.md.

Authority

The PR #8 reviews; docs/RELEASE-ENGINEERING-PLAN.md §9 (a PR must state unverified gaps explicitly).

Stopping condition

Every enumerated finding has a disposition — fixed with a regression test, or rejected with a reason — and the dispositions are recorded.

Verification

cargo test -p app -p engine

Evidence and blockers

The candidate findings are enumerated in the ticket's evidence line and in docs/release/PHASE-0-AUDIT.md §7: editor.rs:619 (drag_quadrangle moves the wrong corners and its doc comment is inaccurate), editor.rs:2376 (Scale/Skew/Distort read document().object_selection instead of the live selection), editor.rs:2595 (Redraw Path drag must send the sampled pointer trace, not a two-point segment), panels_web.rs:574 (unsupported width/height in symbol.createInstance), panels_web.rs:595 (a second symbol/insert_box payload finding), retouch.rs:656 and retouch.rs:1149 (saturating multiplication for a radius→diameter conversion), xtask/src/main.rs:222 (a Minor finding on the release branch), plus documentation-accuracy findings across docs/CS6-PARITY.md, docs/NEXT.md, docs/PROGRESS.md, docs/research/fw-ui-evidence.md, docs/HANDOFF.md, docs/wiki/ and README.md.

PR #8 remains open. The campaign's P2.4 items covering retrieval, per-finding verification, fixes, written rejections, the full application suite, the CI gate and the web build + browser smoke are all unchecked; a triage pass over the review findings is currently in flight, which is why this row is IN PROGRESS rather than NOT STARTED.

Blocker: none.

Ledger: docs/tasks/T27-24-pr8-remaining-findings.md and docs/release/EXECUTION-BOARD.md row T27-24 (these land with PR #12).
Campaign: docs/planning/release-compaign/Cross-Platform Releas.txt.

Lingua principale
Rust
Stelle
11
Fork
1
Merge medio
9h 48m
PR unite (30g)
13

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aliasfoxkde/FireCraft

Tutte le issue di aliasfoxkde/FireCraft

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.