Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Very oldschool x86 signed division by 2 using `sar`+`adc` lifts into something unhelpful

未关闭
#8,457 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
cpp

调研方向

Start with the attached binjabaddiv.zip and inspect the function at 0x40107c in Binary Ninja; compare the lifted SAR/ADC flags and conditional path with signed division by two. Done means this pattern decompiles without an unimplemented carry flag and expresses the intended signed result.

由索引模型根据 Issue 内容生成。

描述

Version and Platform (required):

  • Binary Ninja Version: 5.3.9757 Personal (a99f2380)
  • OS: macOS
  • OS Version: 26.6.1
  • CPU Architecture: ARM64

Bug Description:
I have a target that has been compiled using Borland C++, either version 4.5 or 5.x (from the late 90s). In this compiler, the following code:

int bad_div2(int x) { return x / 2; }

…which computes a signed division by 2, ends up compiling into the following assembly:

	sar       eax,1
	jns	short @3
	adc       eax,0
@3:

After loading this into Binary Ninja, it decompiles into a rather unhelpful:

0040107c    int32_t sub_40107c(int32_t arg1)
0040107c    {
0040107c        int32_t result = arg1 >> 1;
🚫🚫00401082        bool c = /*   bool c = unimplemented  {sar eax, 0x1} */;
00401082        
00401084        if (arg1 >> 1 >= 0)
0040108a            return result;
0040108a        
00401086        return result + 0;
0040107c    }

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. I am attaching a fully-linked EXE which includes this function at address 0x40107c. (Running the EXE doesn't do anything, it's only useful for looking at the function.)

Expected Behavior:
It'd be really nice if this pattern could be recognized and simplified.

Screenshots/Video Recording:
N/A

Binary:
binjabaddiv.zip

Additional Information:
N/A

主要语言
C++
星标
1.3k
派生
298
平均合并
4 天 13 小时
30 天内合并 PR
20

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

Vector35/binaryninja-api 的其他 Issue

查看 Vector35/binaryninja-api 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。