Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Ordered loader: a page-capping provider loses a moved row from a joined window after refetch

未关闭
#2,183 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
18/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
databases

调研方向

Start with the pinned it.fails test in packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts, which encodes the eight-step history against a provider with pageCap 2. Run it to see the failure 'window after refetch at step 3 was []; expected [7]', then trace where the ordered loader's repair path treats a short page as exhaustion. Read PR #2154 on branch fix-query-db-refetch-ordered-gap first. Done when the test passes without the it.fails marker and the refetch oracle's generated scenarios accept pageCap.

由索引模型根据 Issue 内容生成。

描述

Summary

With a provider that returns fewer rows than a request's limit (a page cap), an on-demand joined ordered window can lose a row after a refetch. The row's order changed, and the loader's own repair drops it. A short reply does not prove that the source is exhausted (glossary), so the loader must keep reading.

Reproduction

The pinned witness is a capped provider keeps a moved row in the window after a refetch (known loader defect) in packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts (branch fix-query-db-refetch-ordered-gap, PR #2154). It is an it.fails test today.

  • Provider: cursor encoding, pageCap: 2.
  • Query: rank desc, offset 1, limit 2, LEFT-joined marker filter.
  • Initial rows: id 0 (rank 1, marked), id 1 (rank 0, unmarked).
  • History:
    1. Mark id 7.
    2. Upsert id 2 at rank 1.
    3. Upsert id 7 at rank 0.
    4. Refetch.
    5. Delete id 3.
    6. Invalidate.
    7. Upsert id 3 at rank 1.
    8. Upsert id 0 at rank 0.

Failure: window after refetch at step 3 was []; expected [7].

Scope

This reproduces on main, through the loader's own repair. It is separate from #2136. The query-db refetch oracle's generated campaigns use an uncapped provider because of this defect. A page-capped trace together with a peer live query also fails (found while #2154 was reviewed). That trace fails the same way with the loader's first-page skip disabled.

Suggested witness and owner

  • Owner: the ordered loader. The repair and continuation path must treat a short page as "not exhausted".
  • Witness: flip the pinned it.fails test, then add pageCap to the query-db refetch oracle's generated scenario.

This issue was written by Isaac.

主要语言
TypeScript
星标
3.9k
派生
272
平均合并
22 小时 54 分钟
30 天内合并 PR
236

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TanStack/db 的其他 Issue

查看 TanStack/db 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。