Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Ordered loader: a page-capping provider loses a moved row from a joined window after refetch

Ouverte
  • Quelque chose ne va pas ?
#2,183 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
18/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
databases

Piste de recherche

Start with the pinned it.fails test in packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts, which encodes the eight-step history against a provider with pageCap 2. Run it to see the failure 'window after refetch at step 3 was []; expected [7]', then trace where the ordered loader's repair path treats a short page as exhaustion. Read PR #2154 on branch fix-query-db-refetch-ordered-gap first. Done when the test passes without the it.fails marker and the refetch oracle's generated scenarios accept pageCap.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

With a provider that returns fewer rows than a request's limit (a page cap), an on-demand joined ordered window can lose a row after a refetch. The row's order changed, and the loader's own repair drops it. A short reply does not prove that the source is exhausted (glossary), so the loader must keep reading.

Reproduction

The pinned witness is a capped provider keeps a moved row in the window after a refetch (known loader defect) in packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts (branch fix-query-db-refetch-ordered-gap, PR #2154). It is an it.fails test today.

  • Provider: cursor encoding, pageCap: 2.
  • Query: rank desc, offset 1, limit 2, LEFT-joined marker filter.
  • Initial rows: id 0 (rank 1, marked), id 1 (rank 0, unmarked).
  • History:
    1. Mark id 7.
    2. Upsert id 2 at rank 1.
    3. Upsert id 7 at rank 0.
    4. Refetch.
    5. Delete id 3.
    6. Invalidate.
    7. Upsert id 3 at rank 1.
    8. Upsert id 0 at rank 0.

Failure: window after refetch at step 3 was []; expected [7].

Scope

This reproduces on main, through the loader's own repair. It is separate from #2136. The query-db refetch oracle's generated campaigns use an uncapped provider because of this defect. A page-capped trace together with a peer live query also fails (found while #2154 was reviewed). That trace fails the same way with the loader's first-page skip disabled.

Suggested witness and owner

  • Owner: the ordered loader. The repair and continuation path must treat a short page as "not exhausted".
  • Witness: flip the pinned it.fails test, then add pageCap to the query-db refetch oracle's generated scenario.

This issue was written by Isaac.

Langage dominant
TypeScript
Étoiles
3.9k
Forks
272
Merge moyen
22 h 54 min
PR mergées (30 j)
236

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TanStack/db

Toutes les issues de TanStack/db

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.