Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Ordered loader: a page-capping provider loses a moved row from a joined window after refetch

Aperta
  • Qualcosa non va?
#2,183 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
18/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
databases

Direzione di ricerca

Start with the pinned it.fails test in packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts, which encodes the eight-step history against a provider with pageCap 2. Run it to see the failure 'window after refetch at step 3 was []; expected [7]', then trace where the ordered loader's repair path treats a short page as exhaustion. Read PR #2154 on branch fix-query-db-refetch-ordered-gap first. Done when the test passes without the it.fails marker and the refetch oracle's generated scenarios accept pageCap.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

With a provider that returns fewer rows than a request's limit (a page cap), an on-demand joined ordered window can lose a row after a refetch. The row's order changed, and the loader's own repair drops it. A short reply does not prove that the source is exhausted (glossary), so the loader must keep reading.

Reproduction

The pinned witness is a capped provider keeps a moved row in the window after a refetch (known loader defect) in packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts (branch fix-query-db-refetch-ordered-gap, PR #2154). It is an it.fails test today.

  • Provider: cursor encoding, pageCap: 2.
  • Query: rank desc, offset 1, limit 2, LEFT-joined marker filter.
  • Initial rows: id 0 (rank 1, marked), id 1 (rank 0, unmarked).
  • History:
    1. Mark id 7.
    2. Upsert id 2 at rank 1.
    3. Upsert id 7 at rank 0.
    4. Refetch.
    5. Delete id 3.
    6. Invalidate.
    7. Upsert id 3 at rank 1.
    8. Upsert id 0 at rank 0.

Failure: window after refetch at step 3 was []; expected [7].

Scope

This reproduces on main, through the loader's own repair. It is separate from #2136. The query-db refetch oracle's generated campaigns use an uncapped provider because of this defect. A page-capped trace together with a peer live query also fails (found while #2154 was reviewed). That trace fails the same way with the loader's first-page skip disabled.

Suggested witness and owner

  • Owner: the ordered loader. The repair and continuation path must treat a short page as "not exhausted".
  • Witness: flip the pinned it.fails test, then add pageCap to the query-db refetch oracle's generated scenario.

This issue was written by Isaac.

Lingua principale
TypeScript
Stelle
3.9k
Fork
272
Merge medio
1g 21m
PR unite (30g)
241

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/db

Tutte le issue di TanStack/db

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.