report parses every scene-attached script twice (lint and node-paths)
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 重构
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- performance, tooling
调研方向
Read src/scenes/node-paths.ts, src/lint/engine.ts, and src/scenes/report.ts to trace how scripts are parsed in the report flow. Start by checking the existing tests and fixtures, then add a parse counter test for the report path and compare node-path findings before and after the change. Done means each .gd file is parsed once in report and existing node-path findings remain unchanged.
由索引模型根据 Issue 内容生成。
描述
Summary
Node-path validation parses and walks every scene-attached .gd file a second time with tree-sitter. In report, every script is therefore parsed twice: once by lint and once by node-paths. This is now the largest remaining cost in validate-scenes and report.
Where
src/scenes/node-paths.ts:103-108(prefilter, thenparseGDScript),src/scenes/node-paths.ts:39(fullwalk)src/lint/engine.ts:23,src/scenes/report.ts:46-49
Details
Measured CPU-only:
- A tree-sitter parse costs 1.1 to 1.3 ms per file, and the index walk 0.55 to 0.9 ms.
- The prefilter (
$orget_nodeanywhere in the file) lets almost every real script through. - On 3000 attached scripts,
validateNodePathstook 7.4 s warm and 9.6 s cold, about 75% ofvalidate-scenes(10 s). - In
report, about 6.5 s of 20 to 22 s is the second parse and walk.
Suggested fix
- In
report, collect thepathUsesdata during the lint pass, cached per run by relative path, so each script is parsed once. - For standalone
validate-scenes, usefindAll(root, "get_node")/findAll(root, "call")from the shared index instead of a fullwalk, and tighten the prefilter to/\$["'A-Za-z_%]|get_node(_or_null)?\s*\(/.
Acceptance criteria
-
reportparses each.gdfile exactly once (assert with a parse counter in a test). - Node-path findings are unchanged on the existing fixtures.
Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: performance|src/scenes/node-paths.ts|validateNodePaths
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 6
- 平均合并
- 1 天 21 小时
- 30 天内合并 PR
- 8
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/godot-correctness-mcp 的其他 Issue
-
enhancement good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/godot-correctness-mcp#123 ·
维护者通常 2 天内回复
-
dependencies good first issue severity: low
难度 2/5 1-3 小时 新手友好度 82/100
TMHSDigital/godot-correctness-mcp#116 ·
维护者通常 2 天内回复
-
bug good first issue severity: low
难度 2/5 1-3 小时 新手友好度 88/100
TMHSDigital/godot-correctness-mcp#107 ·
维护者通常 2 天内回复
-
bug good first issue severity: low
难度 2/5 1-3 小时 新手友好度 85/100
TMHSDigital/godot-correctness-mcp#106 ·
维护者通常 2 天内回复
-
bug good first issue severity: medium
难度 2/5 1-3 小时 新手友好度 84/100
TMHSDigital/godot-correctness-mcp#105 ·
维护者通常 2 天内回复
查看 TMHSDigital/godot-correctness-mcp 的全部 Issue
相似的 Issue
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
难度 2/5 1-3 小时 新手友好度 76/100
openclaw/openclaw#203385 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
nwverse/persona#12800 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 80/100
维护者通常 1 天内回复
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
microsoft/playwright#44289 ·
维护者通常 1 天内回复
-
good first issue
难度 2/5 半天 新手友好度 65/100
维护者通常 1 天内回复