report parses every scene-attached script twice (lint and node-paths)

Aperta
#127 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript

Direzione di ricerca

Read src/scenes/node-paths.ts, src/lint/engine.ts, and src/scenes/report.ts to trace how scripts are parsed in the report flow. Start by checking the existing tests and fixtures, then add a parse counter test for the report path and compare node-path findings before and after the change. Done means each .gd file is parsed once in report and existing node-path findings remain unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

performance severity: medium

Summary

Node-path validation parses and walks every scene-attached .gd file a second time with tree-sitter. In report, every script is therefore parsed twice: once by lint and once by node-paths. This is now the largest remaining cost in validate-scenes and report.

Where

  • src/scenes/node-paths.ts:103-108 (prefilter, then parseGDScript), src/scenes/node-paths.ts:39 (full walk)
  • src/lint/engine.ts:23, src/scenes/report.ts:46-49

Details

Measured CPU-only:

  • A tree-sitter parse costs 1.1 to 1.3 ms per file, and the index walk 0.55 to 0.9 ms.
  • The prefilter ($ or get_node anywhere in the file) lets almost every real script through.
  • On 3000 attached scripts, validateNodePaths took 7.4 s warm and 9.6 s cold, about 75% of validate-scenes (10 s).
  • In report, about 6.5 s of 20 to 22 s is the second parse and walk.

Suggested fix

  • In report, collect the pathUses data during the lint pass, cached per run by relative path, so each script is parsed once.
  • For standalone validate-scenes, use findAll(root, "get_node") / findAll(root, "call") from the shared index instead of a full walk, and tighten the prefilter to /\$["'A-Za-z_%]|get_node(_or_null)?\s*\(/.

Acceptance criteria

  • report parses each .gd file exactly once (assert with a parse counter in a test).
  • Node-path findings are unchanged on the existing fixtures.

Filed by repo-audit/full-audit at e836036. Severity: medium. Effort: M. audit-key: performance|src/scenes/node-paths.ts|validateNodePaths

Lingua principale
TypeScript
Stelle
0
Fork
6
Merge medio
1g 21h
PR unite (30g)
8

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/godot-correctness-mcp

Tutte le issue di TMHSDigital/godot-correctness-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.