MCP baseline filtering untested for validate_* tools and report categories

未关闭
#112 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
77/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
devtools, testing

调研方向

Start with the baseline filtering in src/tools/scenes.ts and the existing tests in test/tools.test.ts:194-213. Add the listed cases for scene, project config, registry, and report category filtering, path resolution, invalid JSON, and consecutive lint calls. Run npm run build && npm test; done when the new tests pass and the report category counts equal totalFindings.

由索引模型根据 Issue 内容生成。

描述

good first issue severity: low testing

Summary

MCP baseline support is tested only for lint_project and the lint category of project_report. The per-category filtering for scenes, project and registries is never exercised.

Where

  • src/tools/scenes.ts:26-30, src/tools/scenes.ts:62-65, src/tools/scenes.ts:79-85, src/tools/scenes.ts:102-119
  • test/tools.test.ts:194-213

Test cases to add

  • validate_scenes with a valid baseline plus a new broken .tscn: only the new file is returned, and baselined and count are correct.
  • validate_project_config with a baseline: an old bad autoload is absorbed and a new one is reported.
  • validate_registries with a baseline: entries is preserved, and only new dangling paths are returned.
  • project_report with a baseline on a copy of test/fixtures/scene-project: each category is filtered independently, and errorCount + warningCount + infoCount === totalFindings.
  • An absolute baseline path works, and a relative one resolves against the project root.
  • Invalid baseline JSON returns isError.
  • Editing a file between two consecutive lint_project calls is reflected in the second call. This guards the per-run read cache in src/project/files.ts.

Getting started

  • Relevant files: src/tools/scenes.ts, test/tools.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: testing|src/tools/scenes.ts|baseline

主要语言
TypeScript
星标
0
派生
6
平均合并
1 天 21 小时
30 天内合并 PR
8

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

TMHSDigital/godot-correctness-mcp 的其他 Issue

查看 TMHSDigital/godot-correctness-mcp 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。