MCP baseline filtering untested for validate_* tools and report categories

Aperta
#112 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
77/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
devtools, testing

Direzione di ricerca

Start with the baseline filtering in src/tools/scenes.ts and the existing tests in test/tools.test.ts:194-213. Add the listed cases for scene, project config, registry, and report category filtering, path resolution, invalid JSON, and consecutive lint calls. Run npm run build && npm test; done when the new tests pass and the report category counts equal totalFindings.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

good first issue severity: low testing

Summary

MCP baseline support is tested only for lint_project and the lint category of project_report. The per-category filtering for scenes, project and registries is never exercised.

Where

  • src/tools/scenes.ts:26-30, src/tools/scenes.ts:62-65, src/tools/scenes.ts:79-85, src/tools/scenes.ts:102-119
  • test/tools.test.ts:194-213

Test cases to add

  • validate_scenes with a valid baseline plus a new broken .tscn: only the new file is returned, and baselined and count are correct.
  • validate_project_config with a baseline: an old bad autoload is absorbed and a new one is reported.
  • validate_registries with a baseline: entries is preserved, and only new dangling paths are returned.
  • project_report with a baseline on a copy of test/fixtures/scene-project: each category is filtered independently, and errorCount + warningCount + infoCount === totalFindings.
  • An absolute baseline path works, and a relative one resolves against the project root.
  • Invalid baseline JSON returns isError.
  • Editing a file between two consecutive lint_project calls is reflected in the second call. This guards the per-run read cache in src/project/files.ts.

Getting started

  • Relevant files: src/tools/scenes.ts, test/tools.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: testing|src/tools/scenes.ts|baseline

Lingua principale
TypeScript
Stelle
0
Fork
6
Merge medio
1g 21h
PR unite (30g)
8

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/godot-correctness-mcp

Tutte le issue di TMHSDigital/godot-correctness-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.