Add read-only txAdmin status and resource list tools
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start in mcp-server/tools/txadmin_client.py (TxAdminClient.request) and mcp-server/tools/txadmin.py, where txadmin_resource_control only renders txAdmin's toast. Confirm which panel endpoints return server status and resource states, then add read-only tools registered in mcp-server/server.py. Done means both tools return state without side effects and are covered by tests against a fake local panel, with endpoints documented in skills/txadmin-integration/SKILL.md.
由索引模型根据 Issue 内容生成。
描述
Summary
Every txAdmin tool except player search is a write action, and none can report state afterwards. Add read-only tools for server status and the resource list so the agent can confirm that a restart or ensure actually worked.
Where
mcp-server/tools/txadmin.py:39-60(txadmin_server_control)mcp-server/tools/txadmin.py:63-90(txadmin_resource_control, fallback "command sent")mcp-server/tools/txadmin_client.py:156-166(TxAdminClient.request)mcp-server/server.py:139-200(txAdmin tool registrations)
Details
txadmin_resource_control POSTs /fxserver/commands and renders only txAdmin's toast, falling back to Resource '<name>' <action> command sent.. Nothing reports whether the server is online, starting or crashed, which resources are started, or whether a resource failed with a script error.
Impact
After "restart my resource", the agent cannot tell whether the resource came up, which is the core of the edit, restart, verify loop the txAdmin integration exists for.
Suggested fix
- Add
txadmin_status_tool(server status and uptime) andtxadmin_resource_list_tool(filter)returning resource names and states, using txAdmin's existing panel endpoints. Open question: confirm which endpoints and payloads are stable across txAdmin versions. - Optionally let
txadmin_resource_controlpoll the resource state after the command and report "started" or "failed". - Mark both new tools as read-only for MCP clients.
Acceptance criteria
- The agent can query server status and the resource list without side effects.
- Endpoint choices are documented in
skills/txadmin-integration/SKILL.md, including the txAdmin versions tested. - New tools have tests against a fake local panel.
Getting started
- Relevant files:
mcp-server/tools/txadmin.py,mcp-server/tools/txadmin_client.py,mcp-server/server.py - How to run checks: there is no test suite yet; run the MCP server with
cd mcp-server && pip install -r requirements.txt && python server.py, and CI checks live in.github/workflows/validate.yml - Related docs:
skills/txadmin-integration/SKILL.md,docs/ROADMAP.md(Milestone 4)
Filed by repo-audit/full-audit at 701824d. Severity: medium. Effort: S. audit-key: enhancement|mcp-server/tools/txadmin.py|txadmin_status
- 主要语言
- Python
- 星标
- 7
- 派生
- 4
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
TMHSDigital/CFX-Developer-Tools 的其他 Issue
-
help wanted severity: low tech-debt
难度 3/5 1-2 天 新手友好度 45/100
TMHSDigital/CFX-Developer-Tools#79 ·
维护者通常 1 天内回复
-
enhancement help wanted severity: low
难度 3/5 1-2 天 新手友好度 55/100
TMHSDigital/CFX-Developer-Tools#68 ·
维护者通常 1 天内回复
-
help wanted severity: low tech-debt
难度 4/5 3-5 天 新手友好度 35/100
TMHSDigital/CFX-Developer-Tools#66 ·
维护者通常 1 天内回复
-
dependencies severity: low
难度 3/5 1-2 天 新手友好度 65/100
TMHSDigital/CFX-Developer-Tools#62 · 2 条评论 ·
维护者通常 1 天内回复
-
enhancement severity: medium
难度 3/5 1-2 天 新手友好度 55/100
TMHSDigital/CFX-Developer-Tools#58 · 1 条评论 ·
维护者通常 1 天内回复
查看 TMHSDigital/CFX-Developer-Tools 的全部 Issue
相似的 Issue
-
A new VOLTTRON_HOME starts with agent isolation mode on (string comparison of a boolean default)未关闭
难度 2/5 1-3 小时 新手友好度 68/100
-
llm translation
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
FAIRmat-NFDI/sand#239 ·
维护者通常 1 天内回复
-
bug P2
难度 2/5 1-3 小时 新手友好度 72/100
coco-research/coco#539 ·
维护者通常 1 天内回复
-
dependencies
难度 2/5 1-3 小时 新手友好度 62/100
JustBeanie/hass-volcano-hybrid#34 ·
维护者通常 1 天内回复