Add read-only txAdmin status and resource list tools

Aperta
#57 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
devtools

Direzione di ricerca

Start in mcp-server/tools/txadmin_client.py (TxAdminClient.request) and mcp-server/tools/txadmin.py, where txadmin_resource_control only renders txAdmin's toast. Confirm which panel endpoints return server status and resource states, then add read-only tools registered in mcp-server/server.py. Done means both tools return state without side effects and are covered by tests against a fake local panel, with endpoints documented in skills/txadmin-integration/SKILL.md.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement severity: medium

Summary

Every txAdmin tool except player search is a write action, and none can report state afterwards. Add read-only tools for server status and the resource list so the agent can confirm that a restart or ensure actually worked.

Where

  • mcp-server/tools/txadmin.py:39-60 (txadmin_server_control)
  • mcp-server/tools/txadmin.py:63-90 (txadmin_resource_control, fallback "command sent")
  • mcp-server/tools/txadmin_client.py:156-166 (TxAdminClient.request)
  • mcp-server/server.py:139-200 (txAdmin tool registrations)

Details

txadmin_resource_control POSTs /fxserver/commands and renders only txAdmin's toast, falling back to Resource '<name>' <action> command sent.. Nothing reports whether the server is online, starting or crashed, which resources are started, or whether a resource failed with a script error.

Impact

After "restart my resource", the agent cannot tell whether the resource came up, which is the core of the edit, restart, verify loop the txAdmin integration exists for.

Suggested fix

  • Add txadmin_status_tool (server status and uptime) and txadmin_resource_list_tool(filter) returning resource names and states, using txAdmin's existing panel endpoints. Open question: confirm which endpoints and payloads are stable across txAdmin versions.
  • Optionally let txadmin_resource_control poll the resource state after the command and report "started" or "failed".
  • Mark both new tools as read-only for MCP clients.

Acceptance criteria

  • The agent can query server status and the resource list without side effects.
  • Endpoint choices are documented in skills/txadmin-integration/SKILL.md, including the txAdmin versions tested.
  • New tools have tests against a fake local panel.

Getting started

  • Relevant files: mcp-server/tools/txadmin.py, mcp-server/tools/txadmin_client.py, mcp-server/server.py
  • How to run checks: there is no test suite yet; run the MCP server with cd mcp-server && pip install -r requirements.txt && python server.py, and CI checks live in .github/workflows/validate.yml
  • Related docs: skills/txadmin-integration/SKILL.md, docs/ROADMAP.md (Milestone 4)

Filed by repo-audit/full-audit at 701824d. Severity: medium. Effort: S. audit-key: enhancement|mcp-server/tools/txadmin.py|txadmin_status

Lingua principale
Python
Stelle
7
Fork
4
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/CFX-Developer-Tools

Tutte le issue di TMHSDigital/CFX-Developer-Tools

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.