Add read-only txAdmin status and resource list tools

Aberta
#57 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
42/100
Tipo de issue
Funcionalidade
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
python
Domínio
devtools

Direção de pesquisa

Start in mcp-server/tools/txadmin_client.py (TxAdminClient.request) and mcp-server/tools/txadmin.py, where txadmin_resource_control only renders txAdmin's toast. Confirm which panel endpoints return server status and resource states, then add read-only tools registered in mcp-server/server.py. Done means both tools return state without side effects and are covered by tests against a fake local panel, with endpoints documented in skills/txadmin-integration/SKILL.md.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

enhancement severity: medium

Summary

Every txAdmin tool except player search is a write action, and none can report state afterwards. Add read-only tools for server status and the resource list so the agent can confirm that a restart or ensure actually worked.

Where

  • mcp-server/tools/txadmin.py:39-60 (txadmin_server_control)
  • mcp-server/tools/txadmin.py:63-90 (txadmin_resource_control, fallback "command sent")
  • mcp-server/tools/txadmin_client.py:156-166 (TxAdminClient.request)
  • mcp-server/server.py:139-200 (txAdmin tool registrations)

Details

txadmin_resource_control POSTs /fxserver/commands and renders only txAdmin's toast, falling back to Resource '<name>' <action> command sent.. Nothing reports whether the server is online, starting or crashed, which resources are started, or whether a resource failed with a script error.

Impact

After "restart my resource", the agent cannot tell whether the resource came up, which is the core of the edit, restart, verify loop the txAdmin integration exists for.

Suggested fix

  • Add txadmin_status_tool (server status and uptime) and txadmin_resource_list_tool(filter) returning resource names and states, using txAdmin's existing panel endpoints. Open question: confirm which endpoints and payloads are stable across txAdmin versions.
  • Optionally let txadmin_resource_control poll the resource state after the command and report "started" or "failed".
  • Mark both new tools as read-only for MCP clients.

Acceptance criteria

  • The agent can query server status and the resource list without side effects.
  • Endpoint choices are documented in skills/txadmin-integration/SKILL.md, including the txAdmin versions tested.
  • New tools have tests against a fake local panel.

Getting started

  • Relevant files: mcp-server/tools/txadmin.py, mcp-server/tools/txadmin_client.py, mcp-server/server.py
  • How to run checks: there is no test suite yet; run the MCP server with cd mcp-server && pip install -r requirements.txt && python server.py, and CI checks live in .github/workflows/validate.yml
  • Related docs: skills/txadmin-integration/SKILL.md, docs/ROADMAP.md (Milestone 4)

Filed by repo-audit/full-audit at 701824d. Severity: medium. Effort: S. audit-key: enhancement|mcp-server/tools/txadmin.py|txadmin_status

Linguagem predominante
Python
Estrelas
7
Forks
4
Métricas de merge de PRs
Nenhum PR com merge em 30d

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TMHSDigital/CFX-Developer-Tools

Todas as issues de TMHSDigital/CFX-Developer-Tools

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.