glam v0.33.6 breaks `Vec3A`
@Firestar99 已经在做这个了。
开始于 2026年9月22日。
评估
这个 Issue 还没有评估数据。
描述
PR https://github.com/bitshifter/glam-rs/pull/786 changed the definition of Vec3A to make it bytemuck::Pod:
#[repr(align(16))]
#[repr(C)]
#[cfg_attr(target_arch = "spirv", rust_gpu::vector::v1)]
pub struct Vec3A {
pub x: f32,
pub y: f32,
pub z: f32,
+ _w: f32,
}
So from rust-gpu's perspective, this is now a vector with 4 floats instead of 3 floats, breaking a lot of safety assumptions in our codebase.
Observed Fallout
- breaks rust-gpu's
Matrix4x3layout, causing certain raytracing-related intrinsics to miscompile into invalid spirv. See compiletestray_query_get_intersection_object_to_world_khrbreaking after glam update, as seen in this CI of PR https://github.com/Rust-GPU/rust-gpu/pull/630 - This CI of PR https://github.com/Rust-GPU/rust-gpu/pull/646 shows compiletest
sample_gradientfailing, showing potential higher fallout:
error: error:0:0 - Expected Image Operand Grad dx to have 3 components, but given 4
%38 = OpImageSampleDrefExplicitLod %float %37 %32 %float_1 Grad %33 %34
Mitigation
Problems:
- glam v0.33.6 is a breaking change for rust-gpu
- glam added
_w: f32member to getimpl bytemuck::Pod for Vec3A, so reverting this is a breaking change for regular glam users - don't want
impl Podnot to be impl on spirv
Ideas:
- hack something in the compiler to special case
glam::Vec3A- how do we know if a type is
Vec3A? This will be a hack and not really sustainable
- how do we know if a type is
- PR https://github.com/Rust-GPU/rust-gpu/pull/646 adjusts
Matrix4x3to useVec3instead ofVec3A. The layout of that special type is screwed up anyway, so we don't really care about it changing.- not a full mitigation!
Strategy:
- short term fix
- special case spirv to not have
_w: f32member and not implPod, - release glam v0.33.9, fixing rust-gpu
- long term fix
glam::Vec3A:- remove short term fix
- change attribute to
#[spirv::vector::v1(3, f32)]to overwrite rust-gpu vector type - release glam v0.34.0
- rust-gpu:
- adjust
#[spirv::vector::v1]attribute to take params to overwrite vector type - make rust-gpu support glam v0.34.0
- release rust-gpu?
- adjust
will update this description as I go
- 主要语言
- Rust
- 星标
- 3.4k
- 派生
- 126
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
Rust-GPU/rust-gpu 的其他 Issue
-
enhancement
难度 1/5 1 小时以内 新手友好度 68/100
-
enhancement
-
bug
难度 4/5 3-5 天 新手友好度 48/100
-
bug
难度 3/5 1-2 天 新手友好度 48/100
-
bug
难度 4/5 3-5 天 新手友好度 48/100
查看 Rust-GPU/rust-gpu 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
n0-computer/iroh#4550 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
paritytech/zombienet-sdk#591 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
farion1231/cc-switch#7638 · 1 条评论 ·
-
onnx-ir re-exports ModelProto and GraphProto but not NodeProto, AttributeProto and AttributeType 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 75/100