Fix box: zero size, and dragging a side past its opposite

已关闭
#184 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
50/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp, unity
领域
game-dev

调研方向

The payload names no files, so start by finding the box generator in the Chisel codebase and the check that raises the brushMeshID error. Reproduce it in the Unity editor by sizing a box up and back down to zero height. Done means three things: a zero-size box cancels creation, dragging a side past its opposite gives a negative size with the sides swapped under the hood, and the brush stays valid.

由索引模型根据 Issue 内容生成。

描述

Problems when drawing a box:

  1. Error at zero size while sizing. While building the outline (before the shape is committed), sizing the box upwards and then back downwards until its height is zero gives an error:

    Brush with ID (Chisel.Core.CompactNodeID) has its brushMeshID set to (0), which is invalid.
    The brushMeshID is invalid: a Generator created/didn't update a TreeBrush correctly.
    
  2. A zero-sized box can be made. Finishing with a zero size should cancel the creation instead of making the box.

  3. Dragging a side past its opposite moves the whole box. When a side is moved beyond the opposite side, the opposite side starts following the current position, so the entire box moves. Instead, the opposite side stays where it is and the box gets a negative size; the generator swaps its sides under the hood so the brush is valid.

Rule for all generators: negative sizes are allowed, and every generator builds a valid shape from them (swapping sides under the hood, so the brush is the right way out). A zero size is never allowed: creating at zero size cancels, and an existing generator can't be made zero sized.

Related: capsule (#185), cylinder (#186), inspector values (#187), hemisphere (#188), sphere (#189), extruded shape (#190), linear stairs (#191), spiral stairs (#192).

主要语言
C#
星标
135
派生
15
平均合并
24 分钟
30 天内合并 PR
112

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

RadicalCSG/com.chisel 的其他 Issue

查看 RadicalCSG/com.chisel 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。