build.ps1/build_helpers.ps1 issues
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 35/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- powershell
- 领域
- build-system, tooling
调研方向
Read build.ps1 and tools/build-helpers.ps1, starting with ParseJasmine and RunSpecs, then review ExtractAtom and the build entry points against the linked lines. Done means the listed help, attribute, invocation, path, and parsing issues are addressed without breaking the build or Jasmine output.
由索引模型根据 Issue 内容生成。
描述
Issue Description
build.ps1
- comment based help attempt to include an argument to the example statement, this causes PowerShell to invalidate the comment based help entirely.
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/build.ps1#L10 [cmdletbinding()]and[parameter()]attributes are unnecessary.
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/build.ps1#L28-L33- use of
&(call operator) to execute commands with an unquoted (and non-expanded) name are unnecessary. (3 occurrences total)
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/build.ps1#L41
tools\build_helpers.ps1
function ExtractAtom
- doesn't support UNC paths due to
$PSScriptRootandResolve-Pathwill format with thefilesystem::provider, which notation is not acceptable to[System.IO.Compression.ZipFile]::ExtractToDirectory()method. This is informational only, due to the fact that UNC paths do not work for NPM anyway.
function ParseJasmine
- first line starts with using
$stringparameter, the rest use$_. Surprisingly it works, but only because inRunSpecsthe call toParseJasmineis part of aForEach-Objectwhich populates the$_automatic variable. - the
^\s+Expectedreplacement doesn't seem to be working correctly. Maybe Atom/Atom-Grammar-Test has changed? I think 'to equal' now is to be 'instead found'. - this function should really be a filter as it might provide a better fit. Note, also demonstrating the 'switch' statement with -regex parameter:
This requires changingfilter ParseJasmine { switch -regex ($_) { ^\s+at { '' break } ^\s+it { $_ -replace '^(\s+)(it)', '$1[-] It' break } ^\s+Expected { $_ -replace '^(\s*)(Expected.*?)\s(instead found .*)', "`$1`$2`n`$1`$3" break } default { $_ } } }RunSpecs:
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/tools/build-helpers.ps1#L73
to read more like:& $script:ATOM_EXE_PATH --test $specpath *>&1 | ParseJasmine
function RunSpecs
- quotes around the variable
$script:ATOM_EXE_PATHare unneeded, probably old habit from CMD or another shell? (seen below) - test path 'specs' is literal on ATOM command, but yet in a variable
$specpathin a test previously. Only issue with using the variable is a chance to get the PowerShellfilesystem::provider notation injected.
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/tools/build-helpers.ps1#L72-L73
I'll post a PR shortly demonstrating these changes.
- 主要语言
- PowerShell
- 星标
- 149
- 派生
- 55
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
PowerShell/EditorSyntax 的其他 Issue
-
Tests fail on main branch可能已有人在做 @BryanCuneo 于 18 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
PowerShell/EditorSyntax#227 ·
-
难度 3/5 1-2 天 新手友好度 55/100
PowerShell/EditorSyntax#224 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 48/100
PowerShell/EditorSyntax#222 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 55/100
PowerShell/EditorSyntax#221 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 45/100
PowerShell/EditorSyntax#220 · 2 条评论 · 1 个 reaction ·
查看 PowerShell/EditorSyntax 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
CI does not verify that the committed vanilla-main.css and removed-classes manifest are up to date未关闭bug size: S
难度 2/5 1-3 小时 新手友好度 76/100
-
难度 1/5 1 小时以内 新手友好度 88/100
Zerya-Foundation/hack4krak.pl#950 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
HarperFast/skills#153 ·
-
area: tomb bug priority: low
难度 2/5 1-3 小时 新手友好度 78/100
opensro-dev/opensro#3779 ·
维护者通常 1 天内回复