build.ps1/build_helpers.ps1 issues
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 35/100
- Tipo di issue
- Refactoring
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Ferma
- Stack tecnologico
- powershell
- Ambito
- build-system, tooling
Direzione di ricerca
Read build.ps1 and tools/build-helpers.ps1, starting with ParseJasmine and RunSpecs, then review ExtractAtom and the build entry points against the linked lines. Done means the listed help, attribute, invocation, path, and parsing issues are addressed without breaking the build or Jasmine output.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Issue Description
build.ps1
- comment based help attempt to include an argument to the example statement, this causes PowerShell to invalidate the comment based help entirely.
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/build.ps1#L10 [cmdletbinding()]and[parameter()]attributes are unnecessary.
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/build.ps1#L28-L33- use of
&(call operator) to execute commands with an unquoted (and non-expanded) name are unnecessary. (3 occurrences total)
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/build.ps1#L41
tools\build_helpers.ps1
function ExtractAtom
- doesn't support UNC paths due to
$PSScriptRootandResolve-Pathwill format with thefilesystem::provider, which notation is not acceptable to[System.IO.Compression.ZipFile]::ExtractToDirectory()method. This is informational only, due to the fact that UNC paths do not work for NPM anyway.
function ParseJasmine
- first line starts with using
$stringparameter, the rest use$_. Surprisingly it works, but only because inRunSpecsthe call toParseJasmineis part of aForEach-Objectwhich populates the$_automatic variable. - the
^\s+Expectedreplacement doesn't seem to be working correctly. Maybe Atom/Atom-Grammar-Test has changed? I think 'to equal' now is to be 'instead found'. - this function should really be a filter as it might provide a better fit. Note, also demonstrating the 'switch' statement with -regex parameter:
This requires changingfilter ParseJasmine { switch -regex ($_) { ^\s+at { '' break } ^\s+it { $_ -replace '^(\s+)(it)', '$1[-] It' break } ^\s+Expected { $_ -replace '^(\s*)(Expected.*?)\s(instead found .*)', "`$1`$2`n`$1`$3" break } default { $_ } } }RunSpecs:
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/tools/build-helpers.ps1#L73
to read more like:& $script:ATOM_EXE_PATH --test $specpath *>&1 | ParseJasmine
function RunSpecs
- quotes around the variable
$script:ATOM_EXE_PATHare unneeded, probably old habit from CMD or another shell? (seen below) - test path 'specs' is literal on ATOM command, but yet in a variable
$specpathin a test previously. Only issue with using the variable is a chance to get the PowerShellfilesystem::provider notation injected.
https://github.com/PowerShell/EditorSyntax/blob/cf27d6e54ff9fc593bfb46d22a671898fb31c0a9/tools/build-helpers.ps1#L72-L73
I'll post a PR shortly demonstrating these changes.
- Lingua principale
- PowerShell
- Stelle
- 149
- Fork
- 55
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di PowerShell/EditorSyntax
-
Tests fail on main branchForse già presa @BryanCuneo l’ha presa 18 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
PowerShell/EditorSyntax#227 ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
PowerShell/EditorSyntax#224 · 2 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
PowerShell/EditorSyntax#222 · 2 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
PowerShell/EditorSyntax#221 · 2 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 45/100
PowerShell/EditorSyntax#220 · 2 commenti · 1 reazione ·
Tutte le issue di PowerShell/EditorSyntax
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
btraceio/jafar#228 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
CI does not verify that the committed vanilla-main.css and removed-classes manifest are up to dateApertabug size: S
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
Zerya-Foundation/hack4krak.pl#950 ·
-
Auto-sync generation failureAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
HarperFast/skills#153 ·
-
area: tomb bug priority: low
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
opensro-dev/opensro#3779 ·
I maintainer di solito rispondono entro 1 giorno