test(assets): the Qin-Shi tomb overlay fixture's registry misses the bake switches added since (SRO_JANGAN_TOMB_TELEPORT)

未关闭 适合新手
#3,779 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
go, javascript

调研方向

阅读 scripts/test/assets/qinshiTombOverlay.test.mjs,尤其是 fixtureServerRoot 和失败的指纹测试,然后追踪 buildKnobLines 及其读取的开关列表。更新 fixture,使其注册表行根据该列表生成,并使用每个开关的实际默认值。资产测试通过,并且无需修改测试,添加 bake 开关也不会导致测试失败时,即为完成。

由索引模型根据 Issue 内容生成。

描述

area: tomb bug priority: low

On main, scripts/test/assets/qinshiTombOverlay.test.mjs "a profile or registry flip with the env unset changes the fingerprint and the lane knobs" throws: SRO_JANGAN_TOMB_TELEPORT has no Default in the test's fake registry.

Cause

fixtureServerRoot (line 91) writes a stand-in shardsettings.go with exactly two rows, SRO_QINSHI_TOMB and SRO_MUHAN, because the fingerprint reads every bake switch's posture (buildKnobLines). #3614 added a third bake switch (scripts/build/shared/janganTombTeleport.mjs, read through shardSwitchEnabled), and the fixture was not given its row. The asset tests are not in CI's lanes, so main stayed green.

Fix

The fixture should not hand-list the switches: build its registry rows from the same list buildKnobLines reads (each other switch at its real default), so the next bake switch cannot break this test again. Not a product defect; the release build reads the real registry.

Done when

The test passes on main, and adding a bake switch without touching the test keeps it passing.

主要语言
Go
星标
97
派生
61
平均合并
4 小时 25 分钟
30 天内合并 PR
953

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

opensro-dev/opensro 的其他 Issue

查看 opensro-dev/opensro 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。