How we decide on which scopes to use.
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- powershell
- 领域
- tooling
调研方向
Start by reviewing the scope naming guidance linked in the issue and the related issues #8, #130, and #129. Compare the listed scope-selection and theme-maintenance options, then document an agreed policy covering PowerShell-specific expectations, cross-language consistency, and responsibilities for affected themes.
由索引模型根据 Issue 内容生成。
描述
The use of variable.other.member for properties and methods has been incredibly contentious because most themes don't colour it and some people really don't like the lack of distinction. There has been some suggestion that the grammar should take into account user expectation and/or what themes are or are not doing whether that be the VS Code default themes or some majority of all themes. There is also a question of whether or not grammar maintainers should be responsible for updating the default themes (either before or after making changes to the grammar scopes) if that's even feasible (see below.)
As far as scope selection goes there are a few options:
- Adhere as strictly as possible to https://sublimetext.com/docs/3/scope_naming.html
- Aim for consistency with other languages.
a. Aim for consistency with one other language such as C#.
b. Aim for consistency with as many similar languages as possible. - Make decisions based on maintaining the look and feel at a particular point in time in one or more themes.
- Make decisions based on reaching a similar delineation of language components to ISE, PowerShell Studio, etc again based on what themes are currently doing.
- Use consensus / discussion for each change.
- Other?
I personally prefer a mixture of 1 and 2b which leads to the second question: what level of responsibility do we have to maintain user experience be that in the default themes, the ise them, or some majority of all themes?
- Should we update the default themes to maintain consistency when we make major changes?
- Does it need to occur before/in parallel with our changes?
- Should we update the ISE theme to maintain consistency when we make changes?
- Does it need to occur before/in parallel with our changes?
- Should we update major third party themes to maintain consistency when we make a change?
- Does it need to occur before/in parallel with our changes?
NOTE: When I say "should we update" it could also be an issue/request.
Keeping in mind that if we change to a scope used by other languages that changes to the themes to maintain consistency for PowerShell writers could disturb the expectation of other developers. For example the sigil scope applied to the $ in variables is consistent across almost 10 languages. If we added or removed colour support in the default themes to match PowerShell expectations it could negatively impact other language developers. This raises a final question that goes along with the first one:
- Should we make choices with PowerShell-only expectations in mind.
- Should we make choices with consistency for people who write multiple languages in mind.
Ie, should these look the same between PowerShell and PHP?
$Variable.Property.Method()
$variable->property->method();
Or should the PowerShell one look how it looks in ISE/how it always has looked in VS Code.
Related: #8
Open issues that raise some of these questions: #130 #129
- 主要语言
- PowerShell
- 星标
- 151
- 派生
- 55
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
PowerShell/EditorSyntax 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 55/100
PowerShell/EditorSyntax#224 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 48/100
PowerShell/EditorSyntax#222 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 55/100
PowerShell/EditorSyntax#221 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 45/100
PowerShell/EditorSyntax#220 · 2 条评论 · 1 个 reaction ·
-
Issue-Bug
难度 3/5 1-2 天 新手友好度 48/100
PowerShell/EditorSyntax#219 · 2 条评论 ·
查看 PowerShell/EditorSyntax 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
supermomonga/zcode-acp#24 ·
-
bug
难度 2/5 1-3 小时 新手友好度 90/100
learningequality/ricecooker#747 ·
-
难度 2/5 1-3 小时 新手友好度 84/100
KhronosGroup/glTF-Blender-IO#2769 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 88/100