How we decide on which scopes to use.
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- 機能追加
- 明瞭さ
- 説明が足りない
- 活発さ
- 停滞
- 技術スタック
- powershell
- 領域
- tooling
調査の方向性
Start by reviewing the scope naming guidance linked in the issue and the related issues #8, #130, and #129. Compare the listed scope-selection and theme-maintenance options, then document an agreed policy covering PowerShell-specific expectations, cross-language consistency, and responsibilities for affected themes.
索引モデルが issue の本文から書いたものです。
説明
The use of variable.other.member for properties and methods has been incredibly contentious because most themes don't colour it and some people really don't like the lack of distinction. There has been some suggestion that the grammar should take into account user expectation and/or what themes are or are not doing whether that be the VS Code default themes or some majority of all themes. There is also a question of whether or not grammar maintainers should be responsible for updating the default themes (either before or after making changes to the grammar scopes) if that's even feasible (see below.)
As far as scope selection goes there are a few options:
- Adhere as strictly as possible to https://sublimetext.com/docs/3/scope_naming.html
- Aim for consistency with other languages.
a. Aim for consistency with one other language such as C#.
b. Aim for consistency with as many similar languages as possible. - Make decisions based on maintaining the look and feel at a particular point in time in one or more themes.
- Make decisions based on reaching a similar delineation of language components to ISE, PowerShell Studio, etc again based on what themes are currently doing.
- Use consensus / discussion for each change.
- Other?
I personally prefer a mixture of 1 and 2b which leads to the second question: what level of responsibility do we have to maintain user experience be that in the default themes, the ise them, or some majority of all themes?
- Should we update the default themes to maintain consistency when we make major changes?
- Does it need to occur before/in parallel with our changes?
- Should we update the ISE theme to maintain consistency when we make changes?
- Does it need to occur before/in parallel with our changes?
- Should we update major third party themes to maintain consistency when we make a change?
- Does it need to occur before/in parallel with our changes?
NOTE: When I say "should we update" it could also be an issue/request.
Keeping in mind that if we change to a scope used by other languages that changes to the themes to maintain consistency for PowerShell writers could disturb the expectation of other developers. For example the sigil scope applied to the $ in variables is consistent across almost 10 languages. If we added or removed colour support in the default themes to match PowerShell expectations it could negatively impact other language developers. This raises a final question that goes along with the first one:
- Should we make choices with PowerShell-only expectations in mind.
- Should we make choices with consistency for people who write multiple languages in mind.
Ie, should these look the same between PowerShell and PHP?
$Variable.Property.Method()
$variable->property->method();
Or should the PowerShell one look how it looks in ISE/how it always has looked in VS Code.
Related: #8
Open issues that raise some of these questions: #130 #129
- 主要言語
- PowerShell
- スター
- 151
- フォーク
- 55
- PR マージ指標
- 30日以内にマージされた PR はありません
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
PowerShell/EditorSyntax のほかの issue
-
難易度 3/5 1〜2日 初心者へのやさしさ 55/100
PowerShell/EditorSyntax#224 · コメント 2 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 48/100
PowerShell/EditorSyntax#222 · コメント 2 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 55/100
PowerShell/EditorSyntax#221 · コメント 2 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 45/100
PowerShell/EditorSyntax#220 · コメント 2 件 · リアクション 1 件 ·
-
Issue-Bug
難易度 3/5 1〜2日 初心者へのやさしさ 48/100
PowerShell/EditorSyntax#219 · コメント 2 件 ·
PowerShell/EditorSyntax の issue をすべて見る
似ている issue
-
ZCode 3.14.3 に対応する オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
supermomonga/zcode-acp#24 ·
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 90/100
learningequality/ricecooker#747 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
KhronosGroup/glTF-Blender-IO#2769 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100