How we decide on which scopes to use.
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Estancado
- Stack tecnológico
- powershell
- Área
- tooling
Línea de trabajo
Start by reviewing the scope naming guidance linked in the issue and the related issues #8, #130, and #129. Compare the listed scope-selection and theme-maintenance options, then document an agreed policy covering PowerShell-specific expectations, cross-language consistency, and responsibilities for affected themes.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
The use of variable.other.member for properties and methods has been incredibly contentious because most themes don't colour it and some people really don't like the lack of distinction. There has been some suggestion that the grammar should take into account user expectation and/or what themes are or are not doing whether that be the VS Code default themes or some majority of all themes. There is also a question of whether or not grammar maintainers should be responsible for updating the default themes (either before or after making changes to the grammar scopes) if that's even feasible (see below.)
As far as scope selection goes there are a few options:
- Adhere as strictly as possible to https://sublimetext.com/docs/3/scope_naming.html
- Aim for consistency with other languages.
a. Aim for consistency with one other language such as C#.
b. Aim for consistency with as many similar languages as possible. - Make decisions based on maintaining the look and feel at a particular point in time in one or more themes.
- Make decisions based on reaching a similar delineation of language components to ISE, PowerShell Studio, etc again based on what themes are currently doing.
- Use consensus / discussion for each change.
- Other?
I personally prefer a mixture of 1 and 2b which leads to the second question: what level of responsibility do we have to maintain user experience be that in the default themes, the ise them, or some majority of all themes?
- Should we update the default themes to maintain consistency when we make major changes?
- Does it need to occur before/in parallel with our changes?
- Should we update the ISE theme to maintain consistency when we make changes?
- Does it need to occur before/in parallel with our changes?
- Should we update major third party themes to maintain consistency when we make a change?
- Does it need to occur before/in parallel with our changes?
NOTE: When I say "should we update" it could also be an issue/request.
Keeping in mind that if we change to a scope used by other languages that changes to the themes to maintain consistency for PowerShell writers could disturb the expectation of other developers. For example the sigil scope applied to the $ in variables is consistent across almost 10 languages. If we added or removed colour support in the default themes to match PowerShell expectations it could negatively impact other language developers. This raises a final question that goes along with the first one:
- Should we make choices with PowerShell-only expectations in mind.
- Should we make choices with consistency for people who write multiple languages in mind.
Ie, should these look the same between PowerShell and PHP?
$Variable.Property.Method()
$variable->property->method();
Or should the PowerShell one look how it looks in ISE/how it always has looked in VS Code.
Related: #8
Open issues that raise some of these questions: #130 #129
- Lenguaje dominante
- PowerShell
- Estrellas
- 151
- Forks
- 55
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de PowerShell/EditorSyntax
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
PowerShell/EditorSyntax#224 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
PowerShell/EditorSyntax#222 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
PowerShell/EditorSyntax#221 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
PowerShell/EditorSyntax#220 · 2 comentarios · 1 reacción ·
-
Issue-Bug
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
PowerShell/EditorSyntax#219 · 2 comentarios ·
Todos los issues de PowerShell/EditorSyntax
Issues similares
-
ZCode 3.14.3 に対応する Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
supermomonga/zcode-acp#24 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 90/100
learningequality/ricecooker#747 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
KhronosGroup/glTF-Blender-IO#2769 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100