Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Modeling Events, Event Exclusive Attacks, and Event Items

未关闭
  • 哪里不对？
#1,419 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
停滞
领域
backend-api-design

调研方向

未指定文件、测试或入口点。首先明确事件移动和道具数据模型以及 API 行为，然后确定现有的事件模型和 Pokémon 道具模型；当项目为事件专属招式、完整的事件招式集和事件专属道具确定了统一的表示方式时，即可视为完成。

由索引模型根据 Issue 内容生成。

描述

As suggested by @Naramsim here, and now that the API is being set up to include one time events, I wanted to do some thinking on how event exclusive moves are included.

We'll use the Pokecenter New York Wish Eggs as an example, as they are very well documented.

These pokemon have both:

  • A unique method of obtaining them (event)
  • Unique moves that can only be obtained from said event.

The way I've modeled events in #1417 is that each event has a unique encounter method.

I am of the opinion that it's the right idea to also give each event an identically titled move method identifier, to show what moves the Pokémon comes with from the event

So in this case, any of the wish eggs would have the encounter_method AND pokemon_move_method as:

  • new-york-pokecenter-wish-eggs

There is a world where there's a generic identifier called "event", but I think that's less ideal or else "special" moves can all get lumped together in a way where no one could tell where they came from.

I would also be a proponent of documenting a Pokemons entire moveset on event receipt this way, even if they have no moves unique to said event. Sometimes Pokemon can come with egg moves or TMs that would make them slightly easier to train/plan teams for. In addition to that, it makes for a more complete documentation of what the event was, and what a player gets when they receive that Pokemon.

As an example, Chansey would look like this:

  • 113,3,273,12,0,, - Wish, move method 12 would be new-york-pokecenter-wish-eggs.
  • 113,3,230,12,0,, - Sweet scent

The last thing to discuss is items, and it's here that I am unsure. Chansey does not have an item, it comes as an egg. So let's look at Jirachi from the us colosseum bonus disc.

It has a 50% chance to hold a ganlon berry or a salac berry. However, internally in gen 3, if you find a wild jirachi (which is impossible without glitches or hacks), it will hold a star piece. In practice, this information is useless since it won't happen in regular gameplay.

However, it's factually true. You can use glitches to get any Pokemon to spawn, and Jirachi will have this item. Right now pokemon_items is set up like this:

pokemon_id,version_id,item_id,rarity.

I do see some Pokemon have duplicate items here, like Bibarel has a 50% chance for an Oran Berry and a 5% chance for a Sitrus. But for an event case, we would want a specific encounter location or encounter method that's shown to show a different item than usual. I think this would require more than just new rows right? The API would need a new event item column or something.

Thoughts?

主要语言
Python
星标
5.4k
派生
1.2k
平均合并
2 天 6 小时
30 天内合并 PR
16

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

PokeAPI/pokeapi 的其他 Issue

查看 PokeAPI/pokeapi 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。