Modeling Events, Event Exclusive Attacks, and Event Items
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Estancado
- Área
- backend-api-design
Línea de trabajo
No se nombran archivos, pruebas ni puntos de entrada. Primero aclara el movimiento del evento y el modelo de datos de los objetos, así como el comportamiento de la API; después, identifica los modelos existentes de eventos y de objetos de Pokémon. El trabajo estará terminado cuando el proyecto tenga una representación acordada para los movimientos exclusivos de eventos, los conjuntos de movimientos completos de los eventos y los objetos específicos de eventos.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
As suggested by @Naramsim here, and now that the API is being set up to include one time events, I wanted to do some thinking on how event exclusive moves are included.
We'll use the Pokecenter New York Wish Eggs as an example, as they are very well documented.
These pokemon have both:
- A unique method of obtaining them (event)
- Unique moves that can only be obtained from said event.
The way I've modeled events in #1417 is that each event has a unique encounter method.
I am of the opinion that it's the right idea to also give each event an identically titled move method identifier, to show what moves the Pokémon comes with from the event
So in this case, any of the wish eggs would have the encounter_method AND pokemon_move_method as:
new-york-pokecenter-wish-eggs
There is a world where there's a generic identifier called "event", but I think that's less ideal or else "special" moves can all get lumped together in a way where no one could tell where they came from.
I would also be a proponent of documenting a Pokemons entire moveset on event receipt this way, even if they have no moves unique to said event. Sometimes Pokemon can come with egg moves or TMs that would make them slightly easier to train/plan teams for. In addition to that, it makes for a more complete documentation of what the event was, and what a player gets when they receive that Pokemon.
As an example, Chansey would look like this:
113,3,273,12,0,,- Wish, move method 12 would benew-york-pokecenter-wish-eggs.113,3,230,12,0,,- Sweet scent
The last thing to discuss is items, and it's here that I am unsure. Chansey does not have an item, it comes as an egg. So let's look at Jirachi from the us colosseum bonus disc.
It has a 50% chance to hold a ganlon berry or a salac berry. However, internally in gen 3, if you find a wild jirachi (which is impossible without glitches or hacks), it will hold a star piece. In practice, this information is useless since it won't happen in regular gameplay.
However, it's factually true. You can use glitches to get any Pokemon to spawn, and Jirachi will have this item. Right now pokemon_items is set up like this:
pokemon_id,version_id,item_id,rarity.
I do see some Pokemon have duplicate items here, like Bibarel has a 50% chance for an Oran Berry and a 5% chance for a Sitrus. But for an event case, we would want a specific encounter location or encounter method that's shown to show a different item than usual. I think this would require more than just new rows right? The API would need a new event item column or something.
Thoughts?
- Lenguaje dominante
- Python
- Estrellas
- 5.4k
- Forks
- 1.2k
- Merge medio
- 2 d 12 h
- PR fusionados (30 d)
- 18
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de PokeAPI/pokeapi
-
Blank past ability entries Abierto
Dificultad 2/5 1-2 días Aptitud para principiantes 76/100
-
bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
-
openapi integers range. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
-
UV hardlink files Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
-
Ball legality Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
Todos los issues de PokeAPI/pokeapi
Issues similares
-
bug priority:low
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
CyberAgent/psd2svg#436 ·
-
area/install-update comp/cli comp/desktop P3 sweeper:risk-compatibility type/bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
NousResearch/hermes-agent#122386 · 1 comentario ·
-
ai-generated
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
vllm-project/production-stack#1105 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100