Modeling Events, Event Exclusive Attacks, and Event Items
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 25/100
- issue の種類
- 機能追加
- 明瞭さ
- 説明が足りない
- 活発さ
- 停滞
調査の方向性
ファイル、テスト、エントリーポイントは指定されていません。まずイベントの移動とアイテムのデータモデル、およびAPIの動作を明確にし、その後、既存のイベントモデルとPokémonのアイテムモデルを特定してください。イベント限定技、完全なイベント技セット、イベント固有アイテムについて、プロジェクト内で合意された表現が定まっていれば完了です。
索引モデルが issue の本文から書いたものです。
説明
As suggested by @Naramsim here, and now that the API is being set up to include one time events, I wanted to do some thinking on how event exclusive moves are included.
We'll use the Pokecenter New York Wish Eggs as an example, as they are very well documented.
These pokemon have both:
- A unique method of obtaining them (event)
- Unique moves that can only be obtained from said event.
The way I've modeled events in #1417 is that each event has a unique encounter method.
I am of the opinion that it's the right idea to also give each event an identically titled move method identifier, to show what moves the Pokémon comes with from the event
So in this case, any of the wish eggs would have the encounter_method AND pokemon_move_method as:
new-york-pokecenter-wish-eggs
There is a world where there's a generic identifier called "event", but I think that's less ideal or else "special" moves can all get lumped together in a way where no one could tell where they came from.
I would also be a proponent of documenting a Pokemons entire moveset on event receipt this way, even if they have no moves unique to said event. Sometimes Pokemon can come with egg moves or TMs that would make them slightly easier to train/plan teams for. In addition to that, it makes for a more complete documentation of what the event was, and what a player gets when they receive that Pokemon.
As an example, Chansey would look like this:
113,3,273,12,0,,- Wish, move method 12 would benew-york-pokecenter-wish-eggs.113,3,230,12,0,,- Sweet scent
The last thing to discuss is items, and it's here that I am unsure. Chansey does not have an item, it comes as an egg. So let's look at Jirachi from the us colosseum bonus disc.
It has a 50% chance to hold a ganlon berry or a salac berry. However, internally in gen 3, if you find a wild jirachi (which is impossible without glitches or hacks), it will hold a star piece. In practice, this information is useless since it won't happen in regular gameplay.
However, it's factually true. You can use glitches to get any Pokemon to spawn, and Jirachi will have this item. Right now pokemon_items is set up like this:
pokemon_id,version_id,item_id,rarity.
I do see some Pokemon have duplicate items here, like Bibarel has a 50% chance for an Oran Berry and a 5% chance for a Sitrus. But for an event case, we would want a specific encounter location or encounter method that's shown to show a different item than usual. I think this would require more than just new rows right? The API would need a new event item column or something.
Thoughts?
- 主要言語
- Python
- スター
- 5.4k
- フォーク
- 1.2k
- 平均マージ
- 2日 12時間
- マージ済み PR(30日)
- 18
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
PokeAPI/pokeapi のほかの issue
-
難易度 2/5 1〜2日 初心者へのやさしさ 76/100
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
-
難易度 3/5 1〜2日 初心者へのやさしさ 55/100
-
UV hardlink files オープン
難易度 3/5 1〜2日 初心者へのやさしさ 48/100
-
Ball legality オープン
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
PokeAPI/pokeapi の issue をすべて見る
似ている issue
-
agent-ready documentation needs-triage
難易度 1/5 1〜3時間 初心者へのやさしさ 88/100
-
documentation
難易度 1/5 1時間未満 初心者へのやさしさ 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" オープン
難易度 1/5 1時間未満 初心者へのやさしさ 92/100
-
instance instance add
難易度 1/5 1時間未満 初心者へのやさしさ 72/100
searxng/searx-instances#939 · コメント 1 件 ·
-
area-deployment area-integrations triage:bot-seen
難易度 2/5 半日 初心者へのやさしさ 86/100