Seeking feedback before overhauling items
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 20/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 领域
- data
调研方向
先审查 items.csv、链接的 SV 项目列表和差异列表；然后检查受影响的表以及现有的 10000+ ID，再决定所提议的规范重映射是否可接受。完成意味着项目已就如何处理缺失、重命名和空白/??? 项目达成共识，并确定了重映射的具体范围；目前尚未指定实现方式。
由索引模型根据 Issue 内容生成。
描述
I'd really like to add the approximately 350 items we're currently missing (the ones from Legends: Arceus and Scarlet/Violet), but I can't shake the notion that now'd be a good time to take the opportunity to fix all the "misalignment" currently present in items.csv. It's clear that the file has grown organically over the years, with contributors haphazardly discovering missing items and appending them with the next available ID. This system does work, but I think it'd be nice (both aesthetically and in terms of data "purity") if our indexing matched something canonical.
Unsurprisingly, the vast majority of our items are present in SV's list, but there are some discrepancies, namely 40 that are absent and 18 that would need minor renaming (not counting two-digit TMs). There are plenty of gaps in the list, and it's occasionally "obvious" where we could slot in some of our absentees, but that would seem to defeat the purpose. I think it'd be fine to special-case them with 10000+ IDs, the way we do currently for Black Augurite and Peat Block (which I must say is hard to make sense of).
I appreciate that this would involve a great deal of modification to lots of tables, but I'd be happy to script the remapping and presumably make this a non-issue for the foreseeable future (there were only a handful of item index changes between Generations VII and VIII, and none between VIII and IX). It's a fairly invasive change (plus it's not perfectly clear what we should do about the many blank/??? items), so it seemed like a good idea to gauge consensus before proceeding.
- 主要语言
- Python
- 星标
- 5.4k
- 派生
- 1.2k
- 平均合并
- 2 天 6 小时
- 30 天内合并 PR
- 16
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
PokeAPI/pokeapi 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
PokeAPI/pokeapi#1685 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
PokeAPI/pokeapi#1684 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-2 天 新手友好度 76/100
PokeAPI/pokeapi#1631 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 58/100
PokeAPI/pokeapi#1687 · 4 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
PokeAPI/pokeapi#1623 · 3 条评论 ·
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
PedestrianDynamics/pyFDS-Evac#199 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
521xueweihan/HelloGitHub#3790 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
sandialabs/atlas-ui-3#978 ·
维护者通常 1 天内回复
-
area: tests perceived difficulty: 2
难度 2/5 1-3 小时 新手友好度 72/100
Nitjsefnie-Harness-Commons/daedalus#1255 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 86/100
EleutherAI/lm-evaluation-harness#4256 ·
维护者通常 1 天内回复